You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by muratsu <gi...@git.apache.org> on 2015/01/23 20:49:18 UTC
[GitHub] cordova-lib pull request: CB-6973 Improving JSHint for src folder
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-lib/pull/153
CB-6973 Improving JSHint for src folder
Enforcing better JSHint coverage for src\* :
- Move base rules to src\.jshintrc
- Fix previously un-jshinted files
- Remove base rules from individual files to contain exceptions only
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-6973
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/153.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #153
----
commit 4733ee3af6aa313553e4f8443263bcf3ce792e9b
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2015-01-23T19:22:24Z
CB-6973 have base rules in .jshintrc file
commit e6bbb82b7b50dbd49912ceca42d12f68636f3435
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2015-01-23T19:29:53Z
CB-6973 fix existing jshint issues
commit 7ae7f38746744e786dbd648816da7b6168f8223c
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2015-01-23T19:41:47Z
CB-6973 remove base rules from individual files in src
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6973 Improving JSHint for src folder
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-6973 Improving JSHint for src folder
Posted by kamrik <gi...@git.apache.org>.
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/153#issuecomment-71296437
LGTM, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org