You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/16 11:40:16 UTC
Review Request 56746: Custom job.properties are not retained in the
workflow designer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56746/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20041
https://issues.apache.org/jira/browse/AMBARI-20041
Repository: ambari
Description
-------
Custom job.properties are not retained in the workflow designer.
Steps to reproduce :
1) Submit a workflow with custom job properties say oozie.action.sharelib.for.sqoop=sqoop,hive.
2) From the dashboard, select this workflow.
3) When user tries to submit it again, previously included properties are not visible to the user.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js f93e1b8
contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js f364e30
contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js fe60793
contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs ff92f7d
Diff: https://reviews.apache.org/r/56746/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56746: Custom job.properties are not retained in
the workflow designer
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56746/#review165829
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 16, 2017, 11:40 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56746/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20041
> https://issues.apache.org/jira/browse/AMBARI-20041
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Custom job.properties are not retained in the workflow designer.
>
> Steps to reproduce :
> 1) Submit a workflow with custom job properties say oozie.action.sharelib.for.sqoop=sqoop,hive.
> 2) From the dashboard, select this workflow.
> 3) When user tries to submit it again, previously included properties are not visible to the user.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js f93e1b8
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js f364e30
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js fe60793
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs ff92f7d
>
> Diff: https://reviews.apache.org/r/56746/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56746: Custom job.properties are not retained in
the workflow designer
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56746/#review165837
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 16, 2017, 11:40 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56746/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2017, 11:40 a.m.)
>
>
> Review request for Ambari, belliraj hb, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20041
> https://issues.apache.org/jira/browse/AMBARI-20041
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Custom job.properties are not retained in the workflow designer.
>
> Steps to reproduce :
> 1) Submit a workflow with custom job properties say oozie.action.sharelib.for.sqoop=sqoop,hive.
> 2) From the dashboard, select this workflow.
> 3) When user tries to submit it again, previously included properties are not visible to the user.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js f93e1b8
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js f364e30
> contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js fe60793
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 25a3266
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs ff92f7d
>
> Diff: https://reviews.apache.org/r/56746/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>