You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/04 10:07:19 UTC
[GitHub] [maven] sultan opened a new pull request, #901: fix version comparison
sultan opened a new pull request, #901:
URL: https://github.com/apache/maven/pull/901
Following MNG-7559
Treat equally
* 6.1m5
* 6.1m.5
* 6.1m-5
Display parameters as parsed by Maven (in canonical form and as a list of tokens) and comparison result:
1. 6.1m5 -> 6.1-milestone-5; tokens: [6, 1, [milestone, [5]]]
6.1m5 > 6.1m.5
2. 6.1m.5 -> 6.1-m.5; tokens: [6, 1, [m, 5]]
6.1m.5 > 6.1m-5
3. 6.1m-5 -> 6.1-m-5; tokens: [6, 1, [m, [5]]]
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] sultan commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1356858811
i also think the specs lacks this PR new cases and that they need to be discussed and the expectation decided before continuing this draft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1356852893
Is this a followup to https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] sultan commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1356857958
> > > Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)?
> >
> >
> > different test cases, i consider opening a JIRA before making this ready for peer review
>
> I am inclined to revert the badly attributed commit and give you time to make it proper for all lines of Maven. WDYT?
you can revert the initial PR, so i can make the same pull request again with the same fix.
if these new identified edge cases really are issues that need to be adressed we need an issue listing them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1362598742
This seems to be superseded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o closed pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #901: fix version comparison
URL: https://github.com/apache/maven/pull/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1356855453
> > Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)?
>
> different test cases, i consider opening a JIRA before making this ready for peer review
I am inclined to revert the badly attributed commit and give you time to make it proper for all lines of Maven. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] sultan commented on pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
sultan commented on PR #901:
URL: https://github.com/apache/maven/pull/901#issuecomment-1356855240
> Is this a followup to [97e8bf6](https://github.com/apache/maven/commit/97e8bf67113a9697ff8940b0b65b3e4d7bd3c28a)?
different test cases, i consider opening a JIRA before making this ready for peer review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] sultan closed pull request #901: fix version comparison
Posted by GitBox <gi...@apache.org>.
sultan closed pull request #901: fix version comparison
URL: https://github.com/apache/maven/pull/901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org