You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2007/01/21 23:58:16 UTC
svn commit: r498477 - in /jakarta/jmeter/branches/rel-2-2:
src/core/org/apache/jmeter/save/OldSaveService.java
src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
xdocs/changes.xml xdocs/usermanual/listeners.xml
Author: sebb
Date: Sun Jan 21 14:58:15 2007
New Revision: 498477
URL: http://svn.apache.org/viewvc?view=rev&rev=498477
Log:
Fix NPE in active thread counts for remote tests
Modified:
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/OldSaveService.java
jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
jakarta/jmeter/branches/rel-2-2/xdocs/usermanual/listeners.xml
Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/OldSaveService.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/OldSaveService.java?view=diff&rev=498477&r1=498476&r2=498477
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/OldSaveService.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/OldSaveService.java Sun Jan 21 14:58:15 2007
@@ -468,7 +468,13 @@
}
if (saveConfig.saveThreadCounts()) {
- text.append(JMeterContextService.getContext().getThreadGroup().getNumberOfThreads());
+ org.apache.jmeter.threads.ThreadGroup
+ threadGroup=JMeterContextService.getContext().getThreadGroup();
+ int numThreads =0;
+ if (threadGroup != null) { // can be null for remote testing
+ numThreads = threadGroup.getNumberOfThreads();
+ }
+ text.append(numThreads);
text.append(delimiter);
text.append(JMeterContextService.getNumberOfThreads());
text.append(delimiter);
Modified: jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java?view=diff&rev=498477&r1=498476&r2=498477
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java (original)
+++ jakarta/jmeter/branches/rel-2-2/src/core/org/apache/jmeter/save/converters/SampleResultConverter.java Sun Jan 21 14:58:15 2007
@@ -252,8 +252,14 @@
if (save.saveBytes())
writer.addAttribute(ATT_BYTES, String.valueOf(res.getBytes()));
if (save.saveThreadCounts()){// These cannot be restored
+ org.apache.jmeter.threads.ThreadGroup
+ threadGroup=JMeterContextService.getContext().getThreadGroup();
+ int numThreads =0;
+ if (threadGroup != null) { // can be null for remote testing
+ numThreads = threadGroup.getNumberOfThreads();
+ }
writer.addAttribute(ATT_GRP_THRDS,
- String.valueOf(JMeterContextService.getContext().getThreadGroup().getNumberOfThreads()));
+ String.valueOf(numThreads));
writer.addAttribute(ATT_ALL_THRDS,
String.valueOf(JMeterContextService.getNumberOfThreads()));
}
Modified: jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml?view=diff&rev=498477&r1=498476&r2=498477
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/changes.xml Sun Jan 21 14:58:15 2007
@@ -29,7 +29,8 @@
<h3>Version 2.2.1</h3>
<h4>Known problems:</h4>
-<p>As for 2.2 except as noted below.</p>
+<p>Thread active counts are always zero in CSV and XML files when running remote tests.
+</p>
<h4>Incompatible changes:</h4>
<p>
@@ -67,6 +68,7 @@
<li>Fix ClassCast Exception when using sampler that returns null, e..g TestAction</li>
<li>Bug 41277 - add Latency and Encoding to CSV output</li>
<li>Bug 41414 - Mac OS X may add extra item to -jar classpath</li>
+<li>Fix NPE when saving thread counts in remote testing</li>
</ul>
<h3>Version 2.2</h3>
Modified: jakarta/jmeter/branches/rel-2-2/xdocs/usermanual/listeners.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/branches/rel-2-2/xdocs/usermanual/listeners.xml?view=diff&rev=498477&r1=498476&r2=498477
==============================================================================
--- jakarta/jmeter/branches/rel-2-2/xdocs/usermanual/listeners.xml (original)
+++ jakarta/jmeter/branches/rel-2-2/xdocs/usermanual/listeners.xml Sun Jan 21 14:58:15 2007
@@ -110,6 +110,8 @@
<li>failureMessage - if any</li>
<li>bytes - number of bytes in the sample</li>
<li>URL</li>
+<li>latency - time to first response</li>
+<li>encoding</li>
</ul>
<p>
The format of the XML files is as follows:
@@ -247,6 +249,10 @@
<tr><td>ng</td><td>Number of active threads in this group</td></tr>
<tr><td>na</td><td>Number of active threads for all thread groups</td></tr>
</table>
+<note>
+The active thread counts are always zero for remote tests.
+This is a restriction of the current implementation (2.2.1)
+</note>
<p>
Versions 2.1 and 2.1.1 of JMeter saved the Response Code as "rs", but read it back expecting to find "rc".
This has been corrected so that it is always saved as "rc"; either "rc" or "rs" can be read.
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org