You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "amh1k (via GitHub)" <gi...@apache.org> on 2026/07/28 09:43:03 UTC

[I] Quote skill-evals test helper paths containing spaces [magpie]

amh1k opened a new issue, #991:
URL: https://github.com/apache/magpie/issues/991

   ### What's broken
   
   `tools/skill-evals/tests/test_runner.py` builds grader and judge commands with unquoted absolute script paths, so `shlex.split()` breaks when the checkout path contains spaces. Quote those helper paths so the test suite works from directories such as `/home/user/Web Dev/magpie`.
   
   ### Which layer
   
   Python test suite: `tools/skill-evals/tests/test_runner.py`
   
   ### How to reproduce
   
   1. Place the repository in a path containing a space, for example `/home/user/Web Dev/magpie`.
   2. Run:
   
      ```bash
      uv run --directory tools/skill-evals pytest
   
   ### Expected vs actual
   
   
   **Expected vs actual**
   
   ```md
   Expected: grader and judge helper scripts run successfully regardless of spaces in the checkout path, and the `tools/skill-evals` test suite passes.
   
   Actual: the helper command is split at the space in the absolute path, causing five grader/judge-related tests to fail.
   
   ### Surface area (optional)
   
   _No response_
   
   ### Environment (optional)
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Quote skill-evals test helper paths containing spaces [magpie]

Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean closed issue #991: Quote skill-evals test helper paths containing spaces
URL: https://github.com/apache/magpie/issues/991


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Quote skill-evals test helper paths containing spaces [magpie]

Posted by "justinmclean (via GitHub)" <gi...@apache.org>.
justinmclean commented on issue #991:
URL: https://github.com/apache/magpie/issues/991#issuecomment-5102744522

   Thanks for raising this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org