You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Aditya Kishore <ad...@gmail.com> on 2014/04/29 04:29:53 UTC
Re: Review Request 20804: DRILL-494: Support for Storage Plugin Optimizer
Rules
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20804/
-----------------------------------------------------------
(Updated April 28, 2014, 7:29 p.m.)
Review request for drill, Jinfeng Ni and Steven Phillips.
Changes
-------
Addressed review comments.
Summary (updated)
-----------------
DRILL-494: Support for Storage Plugin Optimizer Rules
Bugs: DRILL-494
https://issues.apache.org/jira/browse/DRILL-494
Repository: drill-git
Description
-------
The patch allows individual storage plugins to add custom optimizer rules which can be used to rewrite the query plan, for example a qualified filter can be pushed into the scan operator if the storage engine supports such a capbility.
Diffs (updated)
-----
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java b8b6af4
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java 314e889
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 1492a28
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java a945129
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrule.java 8985a58
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 8892a8f
exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java 3081b46
exec/java-exec/src/main/java/org/apache/drill/exec/store/QueryOptimizerRule.java ec6465e
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java 67f6df3
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginOptimizerRule.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 7a88098
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 73e414c
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/ReadEntryWithPath.java bf1d762
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java 6e87da5
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java 68fee34
exec/java-exec/src/main/java/org/apache/drill/exec/store/direct/DirectGroupScan.java cfbeb83
exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java bf33805
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaGroupScan.java b8b66dc
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java b71784b
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java d9e6795
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java cd7575d
Diff: https://reviews.apache.org/r/20804/diff/
Testing
-------
Thanks,
Aditya Kishore
Re: Review Request 20804: DRILL-494: Support for Storage Plugin Optimizer
Rules
Posted by Steven Phillips <sp...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20804/#review41707
-----------------------------------------------------------
Ship it!
Ship It!
- Steven Phillips
On April 29, 2014, 2:29 a.m., Aditya Kishore wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20804/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 2:29 a.m.)
>
>
> Review request for drill, Jinfeng Ni and Steven Phillips.
>
>
> Bugs: DRILL-494
> https://issues.apache.org/jira/browse/DRILL-494
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> The patch allows individual storage plugins to add custom optimizer rules which can be used to rewrite the query plan, for example a qualified filter can be pushed into the scan operator if the storage engine supports such a capbility.
>
>
> Diffs
> -----
>
> contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseGroupScan.java b8b6af4
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java 314e889
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillRuleSets.java 1492a28
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrel.java a945129
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ScanPrule.java 8985a58
> exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java 8892a8f
> exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractStoragePlugin.java 3081b46
> exec/java-exec/src/main/java/org/apache/drill/exec/store/QueryOptimizerRule.java ec6465e
> exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePlugin.java 67f6df3
> exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginOptimizerRule.java PRE-CREATION
> exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistry.java 7a88098
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatPlugin.java 73e414c
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/ReadEntryWithPath.java bf1d762
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyFormatPlugin.java 6e87da5
> exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/easy/EasyGroupScan.java 68fee34
> exec/java-exec/src/main/java/org/apache/drill/exec/store/direct/DirectGroupScan.java cfbeb83
> exec/java-exec/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java bf33805
> exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaGroupScan.java b8b66dc
> exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java b71784b
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java d9e6795
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java cd7575d
>
> Diff: https://reviews.apache.org/r/20804/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aditya Kishore
>
>