You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/05 22:59:29 UTC
[GitHub] [iceberg] stevenzwu opened a new pull request, #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
stevenzwu opened a new pull request, #6363:
URL: https://github.com/apache/iceberg/pull/6363
… and 1.15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6363:
URL: https://github.com/apache/iceberg/pull/6363#issuecomment-1339205988
@stevenzwu: Any specific change (non-clean backport) to double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #6363:
URL: https://github.com/apache/iceberg/pull/6363#issuecomment-1339676509
there is no diff btw 1.14/1.15 and 1.16 for the test dir
```
➜ iceberg git:(backport-pr-6299) ✗ git diff --no-index flink/v1.14/flink/src/test/java/org/apache/iceberg/flink/source/enumerator flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/enumerator
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #6363:
URL: https://github.com/apache/iceberg/pull/6363#issuecomment-1339669180
no diff btw 1.16 and 1.15
```
➜ iceberg git:(backport-pr-6299) ✗ diff -r flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/ flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/
➜ iceberg git:(backport-pr-6299) ✗
```
diff btw 1.16 and 1.14 source. One is caused by table API change in 1.15. Another diff looks like some whitespace/tab differences
```
➜ iceberg git:(backport-pr-6299) ✗ diff -r flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/ flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/
Only in flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source: .DS_Store
diff --color -r flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java
34d33
< import org.apache.flink.table.connector.ProviderContext;
204,205c203
< public DataStream<RowData> produceDataStream(
< ProviderContext providerContext, StreamExecutionEnvironment execEnv) {
---
> public DataStream<RowData> produceDataStream(StreamExecutionEnvironment execEnv) {
diff --color -r flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/source/ScanContext.java
98a99
> private final int maxPlanningSnapshotCount;
106d106
< private final int maxPlanningSnapshotCount;
140a141
> this.maxPlanningSnapshotCount = maxPlanningSnapshotCount;
149d149
< this.maxPlanningSnapshotCount = maxPlanningSnapshotCount;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on PR #6363:
URL: https://github.com/apache/iceberg/pull/6363#issuecomment-1340027400
thanks @pvary for reviewing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu merged pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
stevenzwu merged PR #6363:
URL: https://github.com/apache/iceberg/pull/6363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #6363: Flink: backport split discovery throttling for FLIP-27 source to 1.14…
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #6363:
URL: https://github.com/apache/iceberg/pull/6363#issuecomment-1339962951
Thanks @stevenzwu for the backport and the detailed diff!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org