You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@logging.apache.org by Антон Кореньков <ko...@gmail.com> on 2019/08/21 15:55:02 UTC

[LOG4J2-2674] CompositeConfiguration misleading configuration source

Hi,

I have a small question described under
https://issues.apache.org/jira/browse/LOG4J2-2674.  The short summary:
CompositeConfiguration uses ConfigurationSource.NULL_SOURCE. It's a bit
confusing value for the source field, because it has multiple sources in
fact. Do you mind to change the value of this field to newly created
constant ConfigurationSource.COMPOSITE_SOURCE? If yes, I may submit PR.
Thanks for your time.

With best regards,
Anton Korenkov

Re: [LOG4J2-2674] CompositeConfiguration misleading configuration source

Posted by Matt Sicker <bo...@gmail.com>.

That makes sense to me. Since you already have a Jira issue for it,
feel free to open a PR referencing it.

On Wed, 21 Aug 2019 at 11:00, Антон Кореньков <ko...@gmail.com> wrote:
>
> Hi,
>
> I have a small question described under
> https://issues.apache.org/jira/browse/LOG4J2-2674.  The short summary:
> CompositeConfiguration uses ConfigurationSource.NULL_SOURCE. It's a bit
> confusing value for the source field, because it has multiple sources in
> fact. Do you mind to change the value of this field to newly created
> constant ConfigurationSource.COMPOSITE_SOURCE? If yes, I may submit PR.
> Thanks for your time.
>
> With best regards,
> Anton Korenkov



-- 
Matt Sicker <bo...@gmail.com>