[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1997: DRILL-7604: Allow session options to be set in HTTP queries
URL: https://github.com/apache/drill/pull/1997#discussion_r390649598
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/query/query.ftl
 ##########
 @@ -82,6 +82,16 @@
       Submit
     </button>
     <input type="checkbox" name="forceLimit" value="limit" <#if model.isAutoLimitEnabled()>checked</#if>> Limit results to <input type="text" id="autoLimit" name="autoLimit" min="0" value="${model.getDefaultRowsAutoLimited()?c}" size="6" pattern="[0-9]*"> rows <span class="glyphicon glyphicon-info-sign" title="Limits the number of records retrieved in the query. Ignored if query has a limit already" style="cursor:pointer"></span>
+    <label> Store Format
+      <select name="store.format">
+        <option value="parquet">Parquet</option>
+        <option value="json">JSON</option>
+        <option value="csv">Comma-Separated Values</option>
+        <option value="psv">Pipe-Separated Values</option>
+        <option value="tsv">Tab-Separated Values</option>
 
 Review comment:
   @dobesv As I have stated before, we should not hard-code format names since they can be customized, please remove this part of code, other changes are ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services