You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/11 08:49:41 UTC

[GitHub] [activemq-artemis] gtully commented on a change in pull request #3572: ARTEMIS-3289 Reduce journal appender executor Thread wakeup cost

gtully commented on a change in pull request #3572:
URL: https://github.com/apache/activemq-artemis/pull/3572#discussion_r629975131



##########
File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedFile.java
##########
@@ -48,7 +48,8 @@ private MappedFile(FileChannel channel, MappedByteBuffer byteBuffer, int positio
       this.position = position;
       this.length = length;
       this.byteBufWrapper = Unpooled.wrappedBuffer(buffer);
-      this.channelBufferWrapper = new ChannelBufferWrapper(this.byteBufWrapper, false);
+      // we control channelBufferWrapper life-cycle
+      this.channelBufferWrapper = new ChannelBufferWrapper(this.byteBufWrapper, true);

Review comment:
       I don't see the relevance of this change? can you explain the implication?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org