You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "petern48 (via GitHub)" <gi...@apache.org> on 2025/10/10 04:10:50 UTC

[I] chore(geopandas): Replace `assert_series_equal` calls with `pd.check_pd_series_equal()` [sedona]

petern48 opened a new issue, #2379:
URL: https://github.com/apache/sedona/issues/2379

   While reviewing https://github.com/apache/sedona/pull/2378, I noticed there are some sprinkles of `assert_series_equal()` calls in the test files from earlier development. We should instead use the `self.check_pd_series_equal()` wrapper because it validates that the result of our Geopandas functions is `ps.Series` (pyspark series) and not `pd.Series` (pandas series).
   
   Usually, the `to_pandas()` call is inlined, but sometimes it occurs on another line like below. We should update these cases, too.
   https://github.com/apache/sedona/blob/56f196988fffb0f3fed0bf1c0f4153d41b976a6c/python/tests/geopandas/test_geoseries.py#L672-L674
   
   Definition of Done:
   Running the following grep command should ideally only return the call in the `check_pd_series_equal` function (and the import). There's definitely a lot more than that at the moment. If we can't replace every call, then it's a bad sign that maybe we're returning a non-scalable `pd.Series` instead of the spark version.
   
   ```bash
   grep -r "assert_series_equal" sedona/python/tests/geopandas
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] chore(geopandas): Replace `assert_series_equal` calls with `pd.check_pd_series_equal()` [sedona]

Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 closed issue #2379: chore(geopandas): Replace `assert_series_equal` calls with `pd.check_pd_series_equal()`
URL: https://github.com/apache/sedona/issues/2379


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] chore(geopandas): Replace `assert_series_equal` calls with `pd.check_pd_series_equal()` [sedona]

Posted by "petern48 (via GitHub)" <gi...@apache.org>.
petern48 commented on issue #2379:
URL: https://github.com/apache/sedona/issues/2379#issuecomment-3430470442

   Just did, go for it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] chore(geopandas): Replace `assert_series_equal` calls with `pd.check_pd_series_equal()` [sedona]

Posted by "Subham-KRLX (via GitHub)" <gi...@apache.org>.
Subham-KRLX commented on issue #2379:
URL: https://github.com/apache/sedona/issues/2379#issuecomment-3430429293

   hi I would like to work on this issue can you please assign this issue to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org