You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/02/01 12:00:00 UTC
[PR] Remove dependency on datafusion_catalog from datafusion-cli [datafusion]
alamb opened a new pull request, #14398:
URL: https://github.com/apache/datafusion/pull/14398
## Which issue does this PR close?
I noticed this unnecessary dependency while working on
- https://github.com/apache/datafusion/issues/14008
## Rationale for this change
The `datafusion` crate should have all code / features necessary to use datafusion. Users shouldn't have to also use the subcrates.
## What changes are included in this PR?
Remove dependency on `datafusion_catalog` and use the re-export in `datafusion` instead
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove dependency on datafusion_catalog from datafusion-cli [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14398:
URL: https://github.com/apache/datafusion/pull/14398#issuecomment-2631418328
The code is flowing fast today. Love it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove dependency on datafusion_catalog from datafusion-cli [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #14398:
URL: https://github.com/apache/datafusion/pull/14398#discussion_r1938262671
##########
datafusion-cli/Cargo.toml:
##########
@@ -48,7 +48,6 @@ datafusion = { path = "../datafusion/core", version = "44.0.0", features = [
"unicode_expressions",
"compression",
] }
-datafusion-catalog = { path = "../datafusion/catalog", version = "44.0.0" }
Review Comment:
the point of the PR is to remove this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove dependency on datafusion_catalog from datafusion-cli [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 merged PR #14398:
URL: https://github.com/apache/datafusion/pull/14398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org