You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/08 17:38:05 UTC
[GitHub] [airflow] potiuk opened a new pull request #18094: Add 'DEFAULT_BRANCH' to docker variables
potiuk opened a new pull request #18094:
URL: https://github.com/apache/airflow/pull/18094
We are now generatnung constraints with better description, and
we include information about DEFAULT_BRANCH (main/v2-1-test etc.)
The scripts to generate the constraints need to get teh variable
passed to docker.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18094: Fix constraints generation scripts
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18094:
URL: https://github.com/apache/airflow/pull/18094#issuecomment-916255608
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18094: Fix constraints generation scripts
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18094:
URL: https://github.com/apache/airflow/pull/18094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18094: Fix constraints generation scripts
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18094:
URL: https://github.com/apache/airflow/pull/18094#issuecomment-916252492
Hey @kaxil @ashb @jhtimmins @uranusjr -> this is the change needed to update the constraint generation after I added the descriptions in constraint files. I already generated new constraints in main, but I need to merge this one and cherry-pick it to v2-1-test to rebuild constraints there.
The constraints have now headers explaining what are they needed for, which branch they were generated for and when, so that it is easier to understand what each constrain set is for:
Example `main` constraints **just** generated:
* https://github.com/apache/airflow/blob/constraints-main/constraints-3.6.txt
* https://github.com/apache/airflow/blob/constraints-main/constraints-no-providers-3.6.txt
* https://github.com/apache/airflow/blob/constraints-main/constraints-source-providers-3.6.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org