You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/23 05:11:33 UTC
[GitHub] [cordova-eslint] erisu opened a new pull request #11:
chore(dependency): drop eslint-config-semistandard
erisu opened a new pull request #11: chore(dependency): drop eslint-config-semistandard
URL: https://github.com/apache/cordova-eslint/pull/11
### Motivation and Context
* Remove the `eslint-config-semistandard` dependency that lacks activity.
The last release was over 7 months ago. The config it self only applies 2 configs which we can manage ourselves. Removing this dependency means we do not need to wait for releases when base configs were updated. It removes an NPM warning when trying to use newer base configs.
### Description
* Remove `eslint-config-semistandard`
* Added `semi` and `no-extra-semi` configs to our base configs.
* Extends `standard` instead of `semistandard`
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-eslint] brodybits commented on a change in pull request
#11: chore(dependency): drop eslint-config-semistandard
Posted by GitBox <gi...@apache.org>.
brodybits commented on a change in pull request #11: chore(dependency): drop eslint-config-semistandard
URL: https://github.com/apache/cordova-eslint/pull/11#discussion_r396402216
##########
File path: lib/base.js
##########
@@ -18,16 +18,20 @@
*/
module.exports = {
- extends: 'semistandard',
+ extends: 'standard',
env: {
- // `semistandard` sets this to true. We reset it here,
+ // `standard` sets this to true. We reset it here,
// to make the config extend logic clearer.
node: false
},
rules: {
indent: ['error', 4],
- camelcase: 'off'
+ camelcase: 'off',
+
+ // semistandard
Review comment:
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-eslint] raphinesse commented on a change in pull request
#11: chore(dependency): drop eslint-config-semistandard
Posted by GitBox <gi...@apache.org>.
raphinesse commented on a change in pull request #11: chore(dependency): drop eslint-config-semistandard
URL: https://github.com/apache/cordova-eslint/pull/11#discussion_r396338853
##########
File path: lib/base.js
##########
@@ -18,16 +18,20 @@
*/
module.exports = {
- extends: 'semistandard',
+ extends: 'standard',
env: {
- // `semistandard` sets this to true. We reset it here,
+ // `standard` sets this to true. We reset it here,
// to make the config extend logic clearer.
node: false
},
rules: {
indent: ['error', 4],
- camelcase: 'off'
+ camelcase: 'off',
+
+ // semistandard
Review comment:
```suggestion
// We replicate the eslint-config-semistandard rules here instead of
// extending that config, since it is poorly maintained.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-eslint] erisu merged pull request #11: chore(dependency):
drop eslint-config-semistandard
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #11: chore(dependency): drop eslint-config-semistandard
URL: https://github.com/apache/cordova-eslint/pull/11
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org