You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/17 21:14:58 UTC

[jira] [Commented] (BEAM-764) Remove cloneAs from PipelineOptions

    [ https://issues.apache.org/jira/browse/BEAM-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583500#comment-15583500 ] 

ASF GitHub Bot commented on BEAM-764:
-------------------------------------

GitHub user peihe opened a pull request:

    https://github.com/apache/incubator-beam/pull/1120

    [BEAM-764] Remove cloneAs from PipelineOptions

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/peihe/incubator-beam rm-clone-as

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1120.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1120
    
----
commit 044b47f0a9c91c92785f86d9879dbfba834c0276
Author: Pei He <pe...@google.com>
Date:   2016-10-17T21:13:42Z

    [BEAM-764] Remove cloneAs from PipelineOptions

----


> Remove cloneAs from PipelineOptions
> -----------------------------------
>
>                 Key: BEAM-764
>                 URL: https://issues.apache.org/jira/browse/BEAM-764
>             Project: Beam
>          Issue Type: Task
>            Reporter: Pei He
>            Assignee: Pei He
>              Labels: codehealth
>
> PipelineOptions.cloneAs was a workaround to support running multiple pipelines in Dataflow examples for a streaming pipeline and its injector.
> After the Beam examples refactoring, cloneAs is no longer needed.
> cloneAs also has known issue, such as: JsonIgnore fields are not cloned, and requires users to manually set them. So, I am deleting it. 
> However, we should figure out a better API and implementation to support running multiple pipelines with the same configurations (whether through PipelineOptions or not).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)