You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2022/12/22 15:53:08 UTC

[GitHub] [shiro] lprimak commented on a diff in pull request #574: [SHIRO-900] Refactor and update pom.xml

lprimak commented on code in PR #574:
URL: https://github.com/apache/shiro/pull/574#discussion_r1055602603


##########
pom.xml:
##########
@@ -1575,6 +1589,16 @@
                 </pluginManagement>
             </build>
         </profile>
+        <profile>
+            <id>jdk11plus</id>
+            <activation>
+                <jdk>[11,)</jdk>
+            </activation>
+            <properties>
+                <failsafe.argLine>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED</failsafe.argLine>
+                <surefire.argLine>-Xshare:off ${failsafe.argLine}</surefire.argLine>

Review Comment:
   If causes warnings. It also passes the J9 tests but I’ll double check 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org