You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by denalex <gi...@git.apache.org> on 2017/03/03 22:58:14 UTC
[GitHub] incubator-hawq pull request #1160: HAWQ-1374. Use variable service name for ...
GitHub user denalex opened a pull request:
https://github.com/apache/incubator-hawq/pull/1160
HAWQ-1374. Use variable service name for RPS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/denalex/incubator-hawq HAWQ-1374
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1160
----
commit 6fbdfa3c929084489d0d3a15acd7e0e076eae139
Author: Alexander Denissov <ad...@pivotal.io>
Date: 2017-03-03T22:56:31Z
HAWQ-1374. Use variable service name for RPS
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1160: HAWQ-1374. Use variable service name for ...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1160#discussion_r104523021
--- Diff: ranger-plugin/service/src/main/java/org/apache/hawq/ranger/authorization/Utils.java ---
@@ -32,9 +32,10 @@
public abstract class Utils {
public static final String HAWQ = "hawq";
+ public static final String APPID = "rps";
public static final String UNKNOWN = "unknown";
- public static final String APP_ID_PROPERTY_ENV = "ranger.hawq.instance";
- public static final String APP_ID_PROPERTY_FILE = "RANGER_HAWQ_INSTANCE";
+ public static final String INSTANCE_PROPERTY_ENV = "ranger.hawq.instance";
--- End diff --
Maybe add "KEY" suffix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1160: HAWQ-1374. Use variable service name for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1160: HAWQ-1374. Use variable service name for ...
Posted by zhangh43 <gi...@git.apache.org>.
Github user zhangh43 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1160#discussion_r104335313
--- Diff: ranger-plugin/scripts/rps.sh ---
@@ -41,6 +41,7 @@ export CATALINA_OPTS="-server -Xms512m -Xmx512m -XX:MaxPermSize=128m
-Dproc_rps -Dversion=${RPS_VERSION}
-Dranger.hawq.instance=${RANGER_HAWQ_INSTANCE}
-Drps.http.port=${RPS_HTTP_PORT} -Drps.https.port=${RPS_HTTPS_PORT}
+ -Dranger.hawq.instance=${RANGER_HAWQ_INSTANCE}
--- End diff --
this line 44 is duplicate with line 42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---