You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2024/03/25 12:55:31 UTC
[PR] Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`" [spark]
MaxGekk opened a new pull request, #45697:
URL: https://github.com/apache/spark/pull/45697
### What changes were proposed in this pull request?
Revert the commit https://github.com/apache/spark/commit/b34178781fdd67dfcfc53e5a00eea0737ee01620
### Why are the changes needed?
The added test fails:
```
[info] - Variant as pretty strings *** FAILED *** (1 millisecond)
[info] org.apache.spark.SparkRuntimeException: [MALFORMED_VARIANT] Variant binary is malformed. Please check the data source is valid. SQLSTATE: 22023
[info] at org.apache.spark.types.variant.VariantUtil.malformedVariant(VariantUtil.java:155)
[info] at org.apache.spark.types.variant.Variant.<init>(Variant.java:41)
[info] at org.apache.spark.unsafe.types.VariantVal.toString(VariantVal.java:108)
[info] at org.apache.spark.sql.catalyst.expressions.Literal.toString(literals.scala:395)
[info] at java.base/java.lang.String.valueOf(String.java:4220)
```
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
GAs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`" [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45697:
URL: https://github.com/apache/spark/pull/45697#issuecomment-2018142993
I have submitted a FOLLOWUP PR to fix this case, here: https://github.com/apache/spark/pull/45702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`" [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45697: Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`"
URL: https://github.com/apache/spark/pull/45697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`" [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45697:
URL: https://github.com/apache/spark/pull/45697#issuecomment-2017942279
cc @panbingkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] Revert "[SPARK-47539][SQL] Make the return value of method `castToString` be `Any => UTF8String`" [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45697:
URL: https://github.com/apache/spark/pull/45697#issuecomment-2018148894
PS: When this PR was submitted, I tested it many times locally. And it was also ok when it was GA.
These two PRs are too close together. This is the first time I have encountered a similar issue.
I am very sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org