[GitHub] utzig closed pull request #976: Fix console echo in minimal console

[GitBox <gi...@apache.org>]

utzig closed pull request #976: Fix console echo in minimal console
URL: https://github.com/apache/mynewt-core/pull/976
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sys/console/minimal/include/console/console.h b/sys/console/minimal/include/console/console.h
index 433400819..5e8eeb21c 100644
--- a/sys/console/minimal/include/console/console.h
+++ b/sys/console/minimal/include/console/console.h
@@ -45,11 +45,7 @@ int console_read(char *str, int cnt, int *newline);
 
 void console_blocking_mode(void);
 void console_non_blocking_mode(void);
-
-static void inline
-console_echo(int on)
-{
-}
+void console_echo(int on);
 
 static int console_printf(const char *fmt, ...)
     __attribute__ ((format (printf, 1, 2)));;
diff --git a/sys/console/minimal/src/console.c b/sys/console/minimal/src/console.c
index 151faccd3..d0fc78691 100644
--- a/sys/console/minimal/src/console.c
+++ b/sys/console/minimal/src/console.c
@@ -63,6 +63,12 @@ console_out(int c)
     return c;
 }
 
+void
+console_echo(int on)
+{
+    echo = on;
+}
+
 void
 console_write(const char *str, int cnt)
 {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services