You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "reiern70 (via GitHub)" <gi...@apache.org> on 2026/03/31 19:59:46 UTC
[PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
reiern70 opened a new pull request, #1412:
URL: https://github.com/apache/wicket/pull/1412
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3139485773
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -40,10 +40,12 @@
jQuery(document).ready(function() {
"use strict";
+ var isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "ernestosemedy (via GitHub)" <gi...@apache.org>.
ernestosemedy commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4328372873
@martin-g
Again green build locally. I have addressed your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4165221748
I can't believe that there is no need of any migrations in wicket-jquery-ajax.js !
The migration guide is rather long - https://jquery.com/upgrade-guide/4.0/. I'd expect something to break but the JS tests pass!
@reiern70 You may want to add jquery-migrate-4.0.2.js next to jquery.js and see whether it reports something.
I think it would be a good idea to contribute it together with jquery.js until Wicket 11.0.0 is about to be released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4170602361
I will enable it and see what fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4430261650
Or maybe because oldActive is not a Jquery Element but document.activeElement :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3138759904
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -40,10 +40,12 @@
jQuery(document).ready(function() {
"use strict";
+ var isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
No sure. I will try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4274530116
Here the JS tests fail the same way as at CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4291163547
https://github.com/apache/wicket/pull/1412/changes/00ee8b91c3f68b438102cc49c31d4760cd239942 should tell Puppeteer to start Chrome without sandbox.
Another way to tell Puppeteer to start in headless mode without sandbox is by `export CI=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4235996761
@reiern70 You need to use `mvn ... -Pjs-test` profile to run the JavaScript unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4663185309
yeah this change https://github.com/apache/wicket/commit/7362447c83c89783d042469a04234f3a980be702#r188185822 causes the problem, when reverting locally the problem goes away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4238113984
> @reiern70 You need to use `mvn ... -Pjs-test` profile to run the JavaScript unit tests.
I can't run them locally...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "ernestosemedy (via GitHub)" <gi...@apache.org>.
ernestosemedy commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3139281917
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -40,10 +40,12 @@
jQuery(document).ready(function() {
"use strict";
+ var isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3139490312
##########
wicket-core/src/test/js/form.js:
##########
@@ -202,7 +202,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
Same
##########
wicket-core/src/test/js/qunit/jquery.mockjax.js:
##########
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4269748004
> > What is the error ?
> > You can also start them via Jetty with https://github.com/apache/wicket/blob/master/testing/wicket-js-tests/src/test/java/org/apache/wicket/testing/jstest/StartJavaScriptTests.java#L41
> > Then you can execute them in a browser with http://localhost:8080/ajax-tests/test/js/all.html?4.0.0
>
> Not able to run test in sandbox mode.
@martin-g I have fixed JavaScript tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "ernestosemedy (via GitHub)" <gi...@apache.org>.
ernestosemedy commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3147051144
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryMigrateResourceReference.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.util.List;
+import org.apache.wicket.Application;
+import org.apache.wicket.markup.head.HeaderItem;
+import org.apache.wicket.markup.head.JavaScriptHeaderItem;
+import org.apache.wicket.request.resource.JavaScriptResourceReference;
+import org.apache.wicket.request.resource.ResourceReference;
+
+
+/**
+ * The jQuery migrate library
+ */
+public class JQueryMigrateResourceReference extends JavaScriptResourceReference
Review Comment:
> I am not sure whether this class should stay. jquery-migrate.js is a helper that should be used while migrating jQuery dependant code from 3.x to 4.x. But once the migration is done it is not needed anymore.
>
> It does not do any harm though.
It is needed by applications wanting to migrate. I.e. I have used it to migrate our app to jQuery 4,0 and updated wicket jQuery AJAX file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4660746277
> the same problem occurs in wicket-autocomplete.js btw
>
> <img alt="image" width="287" height="28" src="https://private-user-images.githubusercontent.com/4069007/605088000-dcce3a11-30f5-4a05-845a-337826b0e5f8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODEwMTQ5MzEsIm5iZiI6MTc4MTAxNDYzMSwicGF0aCI6Ii80MDY5MDA3LzYwNTA4ODAwMC1kY2NlM2ExMS0zMGY1LTRhMDUtODQ1YS0zMzc4MjZiMGU1ZjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDYwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA2MDlUMTQxNzExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZThmMTExZjBiNTgwNjJjYTU3YzMyYjk2YTM0MDg1YjVjZTE2ZGI0ZTliOGNmM2JmY2ZmMzBjNjY5MjBkMDM3MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.Q_ft2GNuO54WQp05zrb23pkatqGrBPd9VljE4MOCqYk">
> The problem with Modal Dialogs is fixed though :)
Could you plaase provide more info? E.g. in which line of code is this? We don't use autocomplete in our projects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4659753308
the same problem occurs in wicket-autocomplete.js btw
<img width="287" height="28" alt="image" src="https://github.com/user-attachments/assets/dcce3a11-30f5-4a05-845a-337826b0e5f8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3133683108
##########
wicket-core/src/test/js/qunit/jquery.mockjax.js:
##########
Review Comment:
We can update it to 2.7.0 from https://github.com/jakerella/jquery-mockjax/blob/master/dist/jquery.mockjax.js
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryMigrateResourceReference.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.util.List;
+import org.apache.wicket.Application;
+import org.apache.wicket.markup.head.HeaderItem;
+import org.apache.wicket.markup.head.JavaScriptHeaderItem;
+import org.apache.wicket.request.resource.JavaScriptResourceReference;
+import org.apache.wicket.request.resource.ResourceReference;
+
+
+/**
+ * The jQuery mirate library
Review Comment:
```suggestion
* The jQuery migrate library
```
##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -183,6 +183,11 @@
}
};
+ Wicket.isFunction = function (f) {
+ return typeof(f) === 'function';
+ };
+
+ Wicket.isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
```suggestion
Wicket.isWindow = function (obj) {
return obj !== null && obj === obj.window;
};
```
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -445,7 +446,7 @@ jQuery(document).ready(function() {
assert.equal(attributes.dt, 'xml', 'data type');
assert.equal(attributes.wr, true, 'wicket ajax response');
assert.equal(attributes.m, 'GET', 'method');
- assert.ok(jQuery.isWindow(attributes.c), 'component');
+ assert.ok(isWindow(attributes.c), 'component');
Review Comment:
```suggestion
assert.ok(Wicket.isWindow(attributes.c), 'component');
```
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
This should be: `if version.startsWith('2') ? "+" : "%20"`
##########
wicket-core/src/test/js/form.js:
##########
@@ -202,7 +202,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
Same here
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -40,10 +40,12 @@
jQuery(document).ready(function() {
"use strict";
+ var isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
Can we use Wicket.isWindow() instead ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3145189270
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
The idea is that the JS tests could be reused to test with any version of jQuery.
http://localhost:8080/ajax-tests/test/js/all.html?4.0.0 will test with jQuery 4.0.0
http://localhost:8080/ajax-tests/test/js/all.html?3.7.1 will test with jQuery 3.7.1
AFAIR `var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";` is checking which major version of jQuery is in use. Both 4.x and 3.x should use `%20` as a space in urls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "ernestosemedy (via GitHub)" <gi...@apache.org>.
ernestosemedy commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3148509852
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
Fixed
##########
wicket-core/src/test/js/form.js:
##########
@@ -202,7 +202,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3032042755
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java:
##########
@@ -36,14 +36,21 @@ public class JQueryResourceReference extends JavaScriptResourceReference
* <strong>Note</strong>: Might not work with old jQuery plugins!
*/
public static final String VERSION_3 = "jquery/jquery-3.7.1.js";
+ public static final String VERSION_4 = "jquery/jquery-4.0.0.js";
public static final JQueryResourceReference INSTANCE_3 = new JQueryResourceReference(VERSION_3);
+ public static final JQueryResourceReference INSTANCE_4 = new JQueryResourceReference(VERSION_4);
public static JQueryResourceReference getV3()
{
return INSTANCE_3;
}
+ public static JQueryResourceReference getV4()
Review Comment:
This link is relevant to wicket-jquery-ui and wiquery but it does not affect wicket-core anyhow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4253135818
> What is the error ?
>
> You can also start them via Jetty with https://github.com/apache/wicket/blob/master/testing/wicket-js-tests/src/test/java/org/apache/wicket/testing/jstest/StartJavaScriptTests.java#L41
>
> Then you can execute them in a browser with http://localhost:8080/ajax-tests/test/js/all.html?4.0.0
Not able to run test in sandbox mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4315371839
Build is green locally
<img width="1240" height="796" alt="image" src="https://github.com/user-attachments/assets/a003d07e-beba-4cb2-b136-7b1bd0b201ce" />
Including JavaScript tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4307463071
we can drop amd.js. No one care about AMD these days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4307708853
> we can drop amd.js. No one cares about AMD these days
Done. Build passes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4297226781
> > > export CI=true
> >
> >
> > With this build blocks at some point
>
> ```
> >> 109 tests completed in 4336ms, with 0 failed, 0 skipped, and 0 todo.
> [INFO]
> [INFO] Running "qunit:amd" (qunit) task
> [INFO] Testing http://localhost:38887/test/js/amd.html?4.0.0 GET /test/js/amd.html?4.0.0 200 0.597 ms - 1200
> [INFO] GET /test/js/qunit/qunit.css 200 0.577 ms - 9726
> [INFO] GET /test/js/amd/require.js 200 0.677 ms - 15825
> [INFO]
> [INFO] >> ReferenceError: QUnit is not defined
> [INFO] >> at <anonymous> (:164:3)
> [INFO] >> at <anonymous> (:282:2)
> [INFO] GET /favicon.ico 404 0.308 ms - 150
> [INFO] Failed to load resource: the server responded with a status of 404 (Not Found)
> [INFO] GET /test/js/amd.js 200 1.083 ms - 2726
> [INFO] GET /test/js/qunit/qunit.js 200 1.179 ms - 279675
> [INFO] GET /main/java/org/apache/wicket/resource/jquery/jquery-4.0.0.js 200 0.553 ms - 255967
> [INFO] GET /main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 200 0.576 ms - 73390
> ```
> > > export CI=true
> >
> >
> > With this build blocks at some point
>
> ```
> >> 109 tests completed in 4336ms, with 0 failed, 0 skipped, and 0 todo.
> [INFO]
> [INFO] Running "qunit:amd" (qunit) task
> [INFO] Testing http://localhost:38887/test/js/amd.html?4.0.0 GET /test/js/amd.html?4.0.0 200 0.597 ms - 1200
> [INFO] GET /test/js/qunit/qunit.css 200 0.577 ms - 9726
> [INFO] GET /test/js/amd/require.js 200 0.677 ms - 15825
> [INFO]
> [INFO] >> ReferenceError: QUnit is not defined
> [INFO] >> at <anonymous> (:164:3)
> [INFO] >> at <anonymous> (:282:2)
> [INFO] GET /favicon.ico 404 0.308 ms - 150
> [INFO] Failed to load resource: the server responded with a status of 404 (Not Found)
> [INFO] GET /test/js/amd.js 200 1.083 ms - 2726
> [INFO] GET /test/js/qunit/qunit.js 200 1.179 ms - 279675
> [INFO] GET /main/java/org/apache/wicket/resource/jquery/jquery-4.0.0.js 200 0.553 ms - 255967
> [INFO] GET /main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 200 0.576 ms - 73390
> ```
> > > export CI=true
> >
> >
> > With this build blocks at some point
>
> ```
> >> 109 tests completed in 4336ms, with 0 failed, 0 skipped, and 0 todo.
> [INFO]
> [INFO] Running "qunit:amd" (qunit) task
> [INFO] Testing http://localhost:38887/test/js/amd.html?4.0.0 GET /test/js/amd.html?4.0.0 200 0.597 ms - 1200
> [INFO] GET /test/js/qunit/qunit.css 200 0.577 ms - 9726
> [INFO] GET /test/js/amd/require.js 200 0.677 ms - 15825
> [INFO]
> [INFO] >> ReferenceError: QUnit is not defined
> [INFO] >> at <anonymous> (:164:3)
> [INFO] >> at <anonymous> (:282:2)
> [INFO] GET /favicon.ico 404 0.308 ms - 150
> [INFO] Failed to load resource: the server responded with a status of 404 (Not Found)
> [INFO] GET /test/js/amd.js 200 1.083 ms - 2726
> [INFO] GET /test/js/qunit/qunit.js 200 1.179 ms - 279675
> [INFO] GET /main/java/org/apache/wicket/resource/jquery/jquery-4.0.0.js 200 0.553 ms - 255967
> [INFO] GET /main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 200 0.576 ms - 73390
> ```
The same as in here
https://github.com/apache/wicket/actions/runs/24739332723/job/72374517805?pr=1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4273965890
All tests passed locally and pur application seems to work fine with a copy
of jquery AJAX.... js file.
Regards -
Ernesto Reinaldo Barreiro
Apache Wicket Committer
On Fri, Apr 17, 2026, 10:35 PM Martin Grigorov ***@***.***>
wrote:
> *martin-g* left a comment (apache/wicket#1412)
> <https://github.com/apache/wicket/pull/1412?email_source=notifications&email_token=AADQ6PZ4EZ5CS3T4WLJMH6D4WLZXTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXGI2TOMZSGA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4272573205>
>
> @reiern70 <https://github.com/reiern70> See my commits. Now the error is
> more clear - [INFO] .Test "non-wicket response." took longer than 3000ms.
> You need to debug
> https://github.com/apache/wicket/blob/ddf0f6da30b237296188bda7bd570b4612356aa4/wicket-core/src/test/js/ajax.js#L206
> and see why it does not work.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/wicket/pull/1412?email_source=notifications&email_token=AADQ6PZ4EZ5CS3T4WLJMH6D4WLZXTA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXGI2TOMZSGA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4272573205>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AADQ6P5DG5MOX2NBOB2FE234WLZXTAVCNFSM6AAAAACXIHYNU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENZSGU3TGMRQGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4225603934
@martin-g test are green locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3071896906
##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -652,14 +652,14 @@
var scName = attrs.sc;
data = data.concat({name: scName, value: 1});
}
- } else if (attrs.c && !jQuery.isWindow(attrs.c)) {
+ } else if (attrs.c != null && !(attrs.c === attrs.c.window)) {
Review Comment:
```suggestion
} else if (attrs.c !== null && attrs.c !== attrs.c.window) {
```
##########
wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js:
##########
@@ -443,7 +443,7 @@
var target;
if (attrs.event) {
target = attrs.event.target;
- } else if (!jQuery.isWindow(attrs.c)) {
+ } else if (attrs.c != null && !(attrs.c === attrs.c.window)) {
Review Comment:
```suggestion
} else if (attrs.c !== null && attrs.c !== attrs.c.window) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4269820650
> > > What is the error ?
> > > You can also start them via Jetty with https://github.com/apache/wicket/blob/master/testing/wicket-js-tests/src/test/java/org/apache/wicket/testing/jstest/StartJavaScriptTests.java#L41
> > > Then you can execute them in a browser with http://localhost:8080/ajax-tests/test/js/all.html?4.0.0
> >
> >
> > Not able to run test in sandbox mode.
>
> @martin-g I have fixed JavaScript tests
https://github.com/apache/wicket/actions/runs/24576240090/job/71862191241#step:8:4355 no idea how to fix this. @martin-g ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4283548418
75 out of 109 have passed for you and then non-wicket response hangs. Same issue as at CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3018153093
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java:
##########
@@ -36,14 +36,21 @@ public class JQueryResourceReference extends JavaScriptResourceReference
* <strong>Note</strong>: Might not work with old jQuery plugins!
*/
public static final String VERSION_3 = "jquery/jquery-3.7.1.js";
+ public static final String VERSION_4 = "jquery/jquery-4.0.0.js";
public static final JQueryResourceReference INSTANCE_3 = new JQueryResourceReference(VERSION_3);
+ public static final JQueryResourceReference INSTANCE_4 = new JQueryResourceReference(VERSION_4);
public static JQueryResourceReference getV3()
{
return INSTANCE_3;
}
+ public static JQueryResourceReference getV4()
Review Comment:
I should have checked the diff before my comment!
The V4 is not in use yet! This is the reason why the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4430239364
After the upgrade to Wicket 10.9.0 we get an Error in the console after closing a Modal Dialog:
trap-focus: error restoring focus. Attempted to set focus to element, but got an exception
<a id="showModal44e" href="#" data-wicketsource="de.bayern.stmelf.racy10.…:DemoModalPanel.java:69">
TypeError: k.trigger is not a function
trapFocus racy10.js:formatted:31300
remove racy10.js:formatted:31258
remove racy10.js:formatted:2643
cleanData racy10.js:formatted:3130
cleanData racy10.js:formatted:7249
replaceWith racy10.js:formatted:3263
I suspect it is because we are still on Jquery 3.7.1 and not Jquery 4, upgrading to Jquery 4 may have other implications so i did not do that yet. I suspect the following change to be the reason:
<img width="1861" height="533" alt="image" src="https://github.com/user-attachments/assets/abb2e12c-aeac-4aa0-80e8-c7d7ffec8b94" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4272573205
@reiern70 See my commits. Now the error is more clear - `[INFO] .Test "non-wicket response." took longer than 3000ms`. You need to debug https://github.com/apache/wicket/blob/ddf0f6da30b237296188bda7bd570b4612356aa4/wicket-core/src/test/js/ajax.js#L206 and see why it does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4297119746
> export CI=true
With this build blocks at some point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3139488576
##########
wicket-core/src/test/js/form.js:
##########
@@ -187,7 +187,7 @@ jQuery(document).ready(function() {
});
queryString = jQuery.param(queryString, true);
- var space = jQuery.fn.jquery.indexOf("3") === 0 ? "%20" : "+";
+ var space = jQuery.fn.jquery.indexOf("4") === 0 ? "%20" : "+";
Review Comment:
If I put 2 tests fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4307441425
@martin-g I might need your help fixing amd.js test when run from maven. Test pass if run from normal browser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4237339638
> @reiern70 You need to use `mvn ... -Pjs-test` profile to run the JavaScript unit tests.
Thanks for the info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4441628402
> > After the upgrade to Wicket 10.9.0 we get an Error in the console after closing a Modal Dialog:
> > trap-focus: error restoring focus. Attempted to set focus to element, but got an exception
> > TypeError: k.trigger is not a function trapFocus racy10.js:formatted:31300 remove racy10.js:formatted:31258 remove racy10.js:formatted:2643 cleanData racy10.js:formatted:3130 cleanData racy10.js:formatted:7249 replaceWith racy10.js:formatted:3263
> > I suspect it is because we are still on Jquery 3.7.1 and not Jquery 4, upgrading to Jquery 4 may have other implications so i did not do that yet. I suspect the following change to be the reason:
> > <img alt="image" width="1861" height="533" src="https://private-user-images.githubusercontent.com/4069007/591056945-abb2e12c-aeac-4aa0-80e8-c7d7ffec8b94.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg1OTA3MzEsIm5iZiI6MTc3ODU5MDQzMSwicGF0aCI6Ii80MDY5MDA3LzU5MTA1Njk0NS1hYmIyZTEyYy1hZWFjLTRhYTAtODBlOC1jN2Q3ZmZlYzhiOTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDUxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA1MTJUMTI1MzUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDY5YjZjNjllNzZiNjc5Mzg0OGNhMTM5ODk2NjcwMmNkYjAwZGRlZjQwNjhjNzE5NzA1N2ExOGQ3NTMwZGQwZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.vi7yDx9HZ6TBLn268tLqhW7buWQj8E1g9JUGvduddtA">
>
> I will have a look ASAP. Thanks for reporting this
https://github.com/apache/wicket/pull/1457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "ernestosemedy (via GitHub)" <gi...@apache.org>.
ernestosemedy commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4430688734
> After the upgrade to Wicket 10.9.0 we get an Error in the console after closing a Modal Dialog:
>
> trap-focus: error restoring focus. Attempted to set focus to element, but got an exception
>
> TypeError: k.trigger is not a function trapFocus racy10.js:formatted:31300 remove racy10.js:formatted:31258 remove racy10.js:formatted:2643 cleanData racy10.js:formatted:3130 cleanData racy10.js:formatted:7249 replaceWith racy10.js:formatted:3263
>
> I suspect it is because we are still on Jquery 3.7.1 and not Jquery 4, upgrading to Jquery 4 may have other implications so i did not do that yet. I suspect the following change to be the reason:
>
> <img alt="image" width="1861" height="533" src="https://private-user-images.githubusercontent.com/4069007/591056945-abb2e12c-aeac-4aa0-80e8-c7d7ffec8b94.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg1OTA3MzEsIm5iZiI6MTc3ODU5MDQzMSwicGF0aCI6Ii80MDY5MDA3LzU5MTA1Njk0NS1hYmIyZTEyYy1hZWFjLTRhYTAtODBlOC1jN2Q3ZmZlYzhiOTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDUxMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA1MTJUMTI1MzUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDY5YjZjNjllNzZiNjc5Mzg0OGNhMTM5ODk2NjcwMmNkYjAwZGRlZjQwNjhjNzE5NzA1N2ExOGQ3NTMwZGQwZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.vi7yDx9HZ6TBLn268tLqhW7buWQj8E1g9JUGvduddtA">
I will have a look ASAP. Thanks for reporting this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3023157528
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryResourceReference.java:
##########
@@ -36,14 +36,21 @@ public class JQueryResourceReference extends JavaScriptResourceReference
* <strong>Note</strong>: Might not work with old jQuery plugins!
*/
public static final String VERSION_3 = "jquery/jquery-3.7.1.js";
+ public static final String VERSION_4 = "jquery/jquery-4.0.0.js";
public static final JQueryResourceReference INSTANCE_3 = new JQueryResourceReference(VERSION_3);
+ public static final JQueryResourceReference INSTANCE_4 = new JQueryResourceReference(VERSION_4);
public static JQueryResourceReference getV3()
{
return INSTANCE_3;
}
+ public static JQueryResourceReference getV4()
Review Comment:
See
https://blog.jqueryui.com/2026/01/jquery-ui-1-14-2-released/
The new release seems to be compatible with 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4291022825
@martin-g I have fixed JS tests. But I can't still do a full build
`Running "qunit:amd" (qunit) task
[INFO] >> There was an error with headless chrome
[INFO] Fatal error: Failed to launch the browser process: Code: null
[INFO]
[INFO] stderr:
[INFO] [211268:211268:0421/132941.299328:FATAL:content/browser/zygote_host/zygote_host_impl_linux.cc:128] No usable sandbox! If you are running on Ubuntu 23.10+ or another Linux distro that has disabled unprivileged user namespaces with AppArmor, see https://chromium.googlesource.com/chromium/src/+/main/docs/security/apparmor-userns-restrictions.md. Otherwise see https://chromium.googlesource.com/chromium/src/+/main/docs/linux/suid_sandbox_development.md for more information on developing with the (older) SUID sandbox. If you want to live dangerously and need an immediate workaround, you can try using --no-sandbox.
[INFO] Received signal 6
[INFO] #0 0x5e82b33aedea (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x4a69de9)
[INFO] #1 0x5e82b9199d84 (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0xa854d83)
[INFO] #2 0x72492c845330 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4532f)
[INFO] #3 0x72492c84527e (/usr/lib/x86_64-linux-gnu/libc.so.6+0x4527d)
[INFO] #4 0x72492c8288ff (/usr/lib/x86_64-linux-gnu/libc.so.6+0x288fe)
[INFO] #5 0x5e82b9190cf5 (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0xa84bcf4)
[INFO] #6 0x5e82b914ff4d (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0xa80af4c)
[INFO] #7 0x5e82b914fead (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0xa80aeac)
[INFO] #8 0x5e82b490edde (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x5fc9ddd)
[INFO] #9 0x5e82b37ce7f9 (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x4e897f8)
[INFO] #10 0x5e82b4657c4b (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x5d12c4a)
[INFO] #11 0x5e82b849cbc7 (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x9b57bc6)
[INFO] #12 0x5e82b465281c (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x5d0d81b)
[INFO] #13 0x5e82b383f30f (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x4efa30e)
[INFO] #14 0x72492c82a1ca (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a1c9)
[INFO] #15 0x72492c82a28b (/usr/lib/x86_64-linux-gnu/libc.so.6+0x2a28a)
[INFO] #16 0x5e82b505430a (/home/reiern70/.cache/puppeteer/chrome/linux-147.0.7727.56/chrome-linux64/chrome+0x670f309)
[INFO] r8: 000023680013c267 r9: 0000000000000001 r10: 0000000000000008 r11: 0000000000000246
[INFO] r12: 0000000000000006 r13: 0000000000000268 r14: 0000000000000016 r15: 00007ffe964ed918
[INFO] di: 0000000000033944 si: 0000000000033944 bp: 00007ffe964ed280 bx: 0000000000033944
[INFO] dx: 0000000000000006 ax: 0000000000000000 cx: 000072492c89eb2c sp: 00007ffe964ed240
[INFO] ip: 000072492c89eb2c efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000004
[INFO] trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000038
[INFO] [end of stack trace]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4283346940
> Here the JS tests fail the same way as at CI
<img width="1433" height="1006" alt="image" src="https://github.com/user-attachments/assets/db9c166f-f21f-4101-b8bc-8b44cd2ae4a0" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-augment (via GitHub)" <gi...@apache.org>.
martin-augment commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4283539512
75 out of 109 have passed for you and then `non-wicket response` hangs. Same issue as at CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4297204292
> > export CI=true
>
> With this build blocks at some point
```
>> 109 tests completed in 4336ms, with 0 failed, 0 skipped, and 0 todo.
[INFO]
[INFO] Running "qunit:amd" (qunit) task
[INFO] Testing http://localhost:38887/test/js/amd.html?4.0.0 GET /test/js/amd.html?4.0.0 200 0.597 ms - 1200
[INFO] GET /test/js/qunit/qunit.css 200 0.577 ms - 9726
[INFO] GET /test/js/amd/require.js 200 0.677 ms - 15825
[INFO]
[INFO] >> ReferenceError: QUnit is not defined
[INFO] >> at <anonymous> (:164:3)
[INFO] >> at <anonymous> (:282:2)
[INFO] GET /favicon.ico 404 0.308 ms - 150
[INFO] Failed to load resource: the server responded with a status of 404 (Not Found)
[INFO] GET /test/js/amd.js 200 1.083 ms - 2726
[INFO] GET /test/js/qunit/qunit.js 200 1.179 ms - 279675
[INFO] GET /main/java/org/apache/wicket/resource/jquery/jquery-4.0.0.js 200 0.553 ms - 255967
[INFO] GET /main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js 200 0.576 ms - 73390
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4239221767
What is the error ?
You can also start them via Jetty with https://github.com/apache/wicket/blob/master/testing/wicket-js-tests/src/test/java/org/apache/wicket/testing/jstest/StartJavaScriptTests.java#L41
Then you can execute them in a browser with http://localhost:8080/ajax-tests/test/js/all.html?4.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #1412:
URL: https://github.com/apache/wicket/pull/1412#discussion_r3145207154
##########
wicket-core/src/main/java/org/apache/wicket/resource/JQueryMigrateResourceReference.java:
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.wicket.resource;
+
+import java.util.List;
+import org.apache.wicket.Application;
+import org.apache.wicket.markup.head.HeaderItem;
+import org.apache.wicket.markup.head.JavaScriptHeaderItem;
+import org.apache.wicket.request.resource.JavaScriptResourceReference;
+import org.apache.wicket.request.resource.ResourceReference;
+
+
+/**
+ * The jQuery migrate library
+ */
+public class JQueryMigrateResourceReference extends JavaScriptResourceReference
Review Comment:
I am not sure whether this class should stay.
jquery-migrate.js is a helper that should be used while migrating jQuery dependant code from 3.x to 4.x. But once the migration is done it is not needed anymore.
It does not do any harm though.
##########
wicket-core/src/test/js/ajax.js:
##########
@@ -40,10 +40,12 @@
jQuery(document).ready(function() {
"use strict";
+ var isWindow = function (obj) { return obj != null && obj === obj.window; };
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4338512844
> Great work, @reiern70 !
Thanks to you for your review and help. Merging now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "reiern70 (via GitHub)" <gi...@apache.org>.
reiern70 commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4442796321
> After the upgrade to Wicket 10.9.0 we get an Error in the console after closing a Modal Dialog:
>
> trap-focus: error restoring focus. Attempted to set focus to element, but got an exception
>
> TypeError: k.trigger is not a function trapFocus racy10.js:formatted:31300 remove racy10.js:formatted:31258 remove racy10.js:formatted:2643 cleanData racy10.js:formatted:3130 cleanData racy10.js:formatted:7249 replaceWith racy10.js:formatted:3263
>
> I suspect it is because we are still on Jquery 3.7.1 and not Jquery 4, upgrading to Jquery 4 may have other implications so i did not do that yet. I suspect the following change to be the reason:
>
> <img alt="image" width="1861" height="533" src="https://private-user-images.githubusercontent.com/4069007/591056945-abb2e12c-aeac-4aa0-80e8-c7d7ffec8b94.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg2ODc2NDcsIm5iZiI6MTc3ODY4NzM0NywicGF0aCI6Ii80MDY5MDA3LzU5MTA1Njk0NS1hYmIyZTEyYy1hZWFjLTRhYTAtODBlOC1jN2Q3ZmZlYzhiOTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDUxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA1MTNUMTU0OTA3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MDdiNDJjYmYyMmM5M2Y2OTBlYmUxN2QzZTE4NDA2MGQ0YzdiOWVmNDExNjJiOTcyNzNkNDViN2NmMjVmMjg5ZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.B-Aefl30rFBtKUUklIIVgALUzCORhNVBWUulXOcpSy0">
Could you please confirm if my latest changes fix your problems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "bitstorm (via GitHub)" <gi...@apache.org>.
bitstorm merged PR #1412:
URL: https://github.com/apache/wicket/pull/1412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WICKET-7179] add support for jQuery 4.0.0 [wicket]
Posted by "renoth (via GitHub)" <gi...@apache.org>.
renoth commented on PR #1412:
URL: https://github.com/apache/wicket/pull/1412#issuecomment-4449124450
Will do tomorrow. We have holiday today ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org