You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/21 10:44:49 UTC
[GitHub] [flink] dawidwys opened a new pull request #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
dawidwys opened a new pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172
Minor change. Forwarding Calcite exception when parsing a sql query
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] libenchao commented on a change in pull request #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#discussion_r382872573
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/calcite/CalciteParser.java
##########
@@ -47,7 +47,7 @@ public SqlNode parse(String sql) {
SqlParser parser = SqlParser.create(sql, config);
return parser.parseStmt();
} catch (SqlParseException e) {
- throw new SqlParserException("SQL parse failed. " + e.getMessage());
+ throw new SqlParserException("SQL parse failed." + e.getMessage(), e);
Review comment:
seems removing a space by mistake
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11172: [FLINK-16067][table]
Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149998196 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149998196) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys closed pull request #11172: [FLINK-16067][table]
Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149998196 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149998196) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/149998196 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149998196) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#discussion_r383323874
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/calcite/CalciteParser.java
##########
@@ -47,7 +47,7 @@ public SqlNode parse(String sql) {
SqlParser parser = SqlParser.create(sql, config);
return parser.parseStmt();
} catch (SqlParseException e) {
- throw new SqlParserException("SQL parse failed. " + e.getMessage());
+ throw new SqlParserException("SQL parse failed." + e.getMessage(), e);
Review comment:
Good catch @libenchao . I fixed it while merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
Hash:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149998196 TriggerType:PUSH TriggerID:7031e428e2c08f96a7e9ef69afd6680c91cdd2bc
-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149998196)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589618638
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7031e428e2c08f96a7e9ef69afd6680c91cdd2bc",
"status" : "FAILURE",
"url" : "https://travis-ci.com/flink-ci/flink/builds/149998196",
"triggerID" : "7031e428e2c08f96a7e9ef69afd6680c91cdd2bc",
"triggerType" : "PUSH"
}, {
"hash" : "7031e428e2c08f96a7e9ef69afd6680c91cdd2bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415",
"triggerID" : "7031e428e2c08f96a7e9ef69afd6680c91cdd2bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/149998196) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#discussion_r383324022
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/calcite/CalciteParser.java
##########
@@ -47,7 +47,7 @@ public SqlNode parse(String sql) {
SqlParser parser = SqlParser.create(sql, config);
return parser.parseStmt();
} catch (SqlParseException e) {
- throw new SqlParserException("SQL parse failed. " + e.getMessage());
+ throw new SqlParserException("SQL parse failed." + e.getMessage(), e);
Review comment:
Good catch @libenchao. Thank you. I fixed it while merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11172: [FLINK-16067][table]
Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589601620
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7031e428e2c08f96a7e9ef69afd6680c91cdd2bc (Fri Feb 21 10:47:51 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] fhueske commented on issue #11172: [FLINK-16067][table]
Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
fhueske commented on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589662463
Thanks for the fix @dawidwys!
The error details are correctly propagated again :-)
+1 to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on issue #11172: [FLINK-16067][table]
Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
dawidwys commented on issue #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#issuecomment-589600587
cc @fhueske
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys commented on a change in pull request #11172:
[FLINK-16067][table] Forward Calcite exception when parsing a sql query
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #11172: [FLINK-16067][table] Forward Calcite exception when parsing a sql query
URL: https://github.com/apache/flink/pull/11172#discussion_r383323874
##########
File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/calcite/CalciteParser.java
##########
@@ -47,7 +47,7 @@ public SqlNode parse(String sql) {
SqlParser parser = SqlParser.create(sql, config);
return parser.parseStmt();
} catch (SqlParseException e) {
- throw new SqlParserException("SQL parse failed. " + e.getMessage());
+ throw new SqlParserException("SQL parse failed." + e.getMessage(), e);
Review comment:
Good catch @libenchao . I fixed it while merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services