You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/23 05:34:00 UTC
[jira] [Commented] (PARQUET-1683) Remove unnecessary string
converting in readFooter method
[ https://issues.apache.org/jira/browse/PARQUET-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957567#comment-16957567 ]
ASF GitHub Bot commented on PARQUET-1683:
-----------------------------------------
Fokko commented on pull request #695: PARQUET-1683: Remove unnecessary string converting in readFooter method
URL: https://github.com/apache/parquet-mr/pull/695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove unnecessary string converting in readFooter method
> ---------------------------------------------------------
>
> Key: PARQUET-1683
> URL: https://issues.apache.org/jira/browse/PARQUET-1683
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Affects Versions: 1.12.0
> Reporter: Xinli Shang
> Priority: Major
> Labels: pull-request-available
>
> The method (String filePath = file.toString()) is always called even filePath is not used(it is only used when an exception is thrown which is rare). This kind of string conversion should be avoided when it is not used in terms of memory & CPU efficiency.
>
> [https://github.com/apache/parquet-mr/pull/695]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)