You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/02 05:01:32 UTC

[GitHub] [hive] kasakrisz commented on a change in pull request #1662: HIVE-24295: Apply schema merge to all shared work optimizations

kasakrisz commented on a change in pull request #1662:
URL: https://github.com/apache/hive/pull/1662#discussion_r568312799



##########
File path: ql/src/test/results/clientpositive/llap/correlationoptimizer2.q.out
##########
@@ -2668,6 +2684,8 @@ STAGE PLANS:
                       input format: org.apache.hadoop.mapred.SequenceFileInputFormat
                       output format: org.apache.hadoop.hive.ql.io.HiveSequenceFileOutputFormat
                       serde: org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/bucket_map_join_tez2.q.out
##########
@@ -1398,6 +1412,12 @@ STAGE PLANS:
                         null sort order: z
                         sort order: +
                         Map-reduce partition columns: _col0 (type: string)
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/except_distinct.q.out
##########
@@ -481,20 +481,32 @@ STAGE PLANS:
                   Select Operator
                     expressions: _col0 (type: string), _col1 (type: string), _col3 (type: bigint), (_col2 * _col3) (type: bigint)
                     outputColumnNames: _col0, _col1, _col2, _col3
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/subquery_exists_having.q.out
##########
@@ -31,13 +31,18 @@ STAGE PLANS:
     Tez
 #### A masked pattern was here ####
       Edges:
-        Reducer 2 <- Map 1 (SIMPLE_EDGE)
-        Reducer 3 <- Map 1 (SIMPLE_EDGE), Reducer 2 (SIMPLE_EDGE)
+        Reducer 2 <- Map 1 (SIMPLE_EDGE), Reducer 3 (SIMPLE_EDGE)
+        Reducer 3 <- Map 1 (SIMPLE_EDGE)
 #### A masked pattern was here ####
       Vertices:
         Map 1 
             Map Operator Tree:
                 TableScan
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out
##########
@@ -183,16 +145,8 @@ STAGE PLANS:
                             sort order: 
                             Statistics: Num rows: 1 Data size: 516 Basic stats: COMPLETE Column stats: NONE
                             value expressions: _col0 (type: decimal(34,16)), _col1 (type: decimal(34,16)), _col2 (type: tinyint), _col3 (type: tinyint), _col4 (type: bigint), _col5 (type: bigint), _col6 (type: binary)
-            Execution mode: vectorized, llap
-            LLAP IO: all inputs
-        Map 7 
-            Map Operator Tree:
-                TableScan
-                  alias: tt2
-                  filterExpr: (timestamp_col_18 is not null and decimal1911_col_16 is not null and decimal1911_col_16 BETWEEN DynamicValue(RS_13_tt1_decimal2612_col_77_min) AND DynamicValue(RS_13_tt1_decimal2612_col_77_max) and in_bloom_filter(decimal1911_col_16, DynamicValue(RS_13_tt1_decimal2612_col_77_bloom_filter))) (type: boolean)
-                  Statistics: Num rows: 1 Data size: 152 Basic stats: COMPLETE Column stats: NONE
                   Filter Operator
-                    predicate: (timestamp_col_18 is not null and decimal1911_col_16 is not null and decimal1911_col_16 BETWEEN DynamicValue(RS_13_tt1_decimal2612_col_77_min) AND DynamicValue(RS_13_tt1_decimal2612_col_77_max) and in_bloom_filter(decimal1911_col_16, DynamicValue(RS_13_tt1_decimal2612_col_77_bloom_filter))) (type: boolean)

Review comment:
       Is semi join opportunity lost here?

##########
File path: ql/src/test/results/clientpositive/llap/except_all.q.out
##########
@@ -495,20 +495,32 @@ STAGE PLANS:
                   Select Operator
                     expressions: _col0 (type: string), _col1 (type: string), _col3 (type: bigint), (_col2 * _col3) (type: bigint)
                     outputColumnNames: _col0, _col1, _col2, _col3
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/reduce_deduplicate_extended2.q.out
##########
@@ -562,39 +562,63 @@ STAGE PLANS:
             Map Operator Tree:
                 TableScan
                   alias: src
-                  Statistics: Num rows: 500 Data size: 43500 Basic stats: COMPLETE Column stats: COMPLETE
+                  Statistics: Num rows: 500 Data size: 45500 Basic stats: COMPLETE Column stats: COMPLETE
                   Select Operator
-                    expressions: key (type: string)
-                    outputColumnNames: key
-                    Statistics: Num rows: 500 Data size: 43500 Basic stats: COMPLETE Column stats: COMPLETE
+                    expressions: value (type: string)
+                    outputColumnNames: value
+                    Statistics: Num rows: 500 Data size: 45500 Basic stats: COMPLETE Column stats: COMPLETE
                     Group By Operator
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/special_character_in_tabnames_quotes_1.q.out
##########
@@ -1623,13 +1623,18 @@ STAGE PLANS:
     Tez
 #### A masked pattern was here ####
       Edges:
-        Reducer 2 <- Map 1 (SIMPLE_EDGE)
-        Reducer 3 <- Map 1 (SIMPLE_EDGE), Reducer 2 (SIMPLE_EDGE)
+        Reducer 2 <- Map 1 (SIMPLE_EDGE), Reducer 3 (SIMPLE_EDGE)
+        Reducer 3 <- Map 1 (SIMPLE_EDGE)
 #### A masked pattern was here ####
       Vertices:
         Map 1 
             Map Operator Tree:
                 TableScan
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/explainuser_1.q.out
##########
@@ -2537,6 +2537,8 @@ Stage-0
         Merge Join Operator [MERGEJOIN_31] (rows=25 width=227)
           Conds:RS_17._col1=RS_18._col0(Left Semi),Output:["_col0","_col1","_col2"]
         <-Reducer 2 [SIMPLE_EDGE] llap
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/sharedwork.q.out
##########
@@ -729,53 +729,79 @@ STAGE PLANS:
                       auto parallelism: true
                   Filter Operator
                     isSamplingPred: false
-                    predicate: p_size is not null (type: boolean)
+                    predicate: (p_size is not null and p_type is not null) (type: boolean)
                     Statistics: Num rows: 26 Data size: 2808 Basic stats: COMPLETE Column stats: COMPLETE
                     Select Operator
-                      expressions: (p_size + 1) (type: int), p_type (type: string)
+                      expressions: p_type (type: string), (p_size + 1) (type: int)
                       outputColumnNames: _col0, _col1
                       Statistics: Num rows: 26 Data size: 2808 Basic stats: COMPLETE Column stats: COMPLETE
                       Group By Operator
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/special_character_in_tabnames_1.q.out
##########
@@ -1451,13 +1451,18 @@ STAGE PLANS:
     Tez
 #### A masked pattern was here ####
       Edges:
-        Reducer 2 <- Map 1 (SIMPLE_EDGE)
-        Reducer 3 <- Map 1 (SIMPLE_EDGE), Reducer 2 (SIMPLE_EDGE)
+        Reducer 2 <- Map 1 (SIMPLE_EDGE), Reducer 3 (SIMPLE_EDGE)
+        Reducer 3 <- Map 1 (SIMPLE_EDGE)
 #### A masked pattern was here ####
       Vertices:
         Map 1 
             Map Operator Tree:
                 TableScan
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/subquery_in.q.out
##########
@@ -1138,6 +1146,9 @@ STAGE PLANS:
                           null sort order: z
                           sort order: +
                           Map-reduce partition columns: _col0 (type: int)
+<<<<<<< HEAD

Review comment:
       Accidentally left here?

##########
File path: ql/src/test/results/clientpositive/llap/subquery_ALL.q.out
##########
@@ -530,10 +531,16 @@ STAGE PLANS:
                         null sort order: z
                         sort order: +
                         Map-reduce partition columns: _col0 (type: int)
+<<<<<<< HEAD

Review comment:
       Accidentally left here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org