You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/06/20 00:47:18 UTC
Re: Review Request: Debianizing files for Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/
-----------------------------------------------------------
(Updated June 19, 2012, 10:47 p.m.)
Review request for mesos.
Changes
-------
Update to current svn; use deploy-script-installed mesos-daemon.sh.
Summary (updated)
-----------------
Debianizing files for Mesos
Description (updated)
-------
This adds files sufficient to build a package for Ubuntu 11.10. Running
./debian/make_snapshot_changelog.sh && debuild -us -uc
should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
Things still to be done to make more generally acceptable Debian packages:
- allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
- package style violations:
- add documentation on how to configure the given startup scripts
- move deploy scripts default config file location to /etc and deploy scripts outside of /var
- add manpages for executables
- fix changelog entries
- support using system versions of third_party libraries, JS libraries
This addresses bug MESOS-74.
https://issues.apache.org/jira/browse/MESOS-74
Diffs (updated)
-----
debian/compat PRE-CREATION
debian/control PRE-CREATION
debian/copyright PRE-CREATION
debian/make_snapshot_changelog.sh PRE-CREATION
debian/mesos.default PRE-CREATION
debian/mesos.mesos-master.upstart PRE-CREATION
debian/mesos.mesos-slave.upstart PRE-CREATION
debian/rules PRE-CREATION
debian/source/format PRE-CREATION
Diff: https://reviews.apache.org/r/2850/diff/
Testing
-------
Thanks,
Charles Reiss
Re: Review Request: Debianizing files for Mesos
Posted by Thomas Dudziak <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10850
-----------------------------------------------------------
debian/rules
<https://reviews.apache.org/r/2850/#comment23390>
This only works for me when inserting this line right before:
DEB_BUILD_ARCH?=$(shell dpkg-architecture -qDEB_BUILD_ARCH)
- Thomas Dudziak
On June 19, 2012, 10:47 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 10:47 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Debianizing files for Mesos
Posted by Charles Reiss <wo...@gmail.com>.
> On Aug. 30, 2012, 9:10 p.m., Thomas Dudziak wrote:
> > debian/mesos.mesos-master.upstart, line 1
> > <https://reviews.apache.org/r/2850/diff/4/?file=112254#file112254line1>
> >
> > Also, for debian, the mesos configuration should probably be in /etc/mesos ?
Done by changing localstatedir at configure time. (Preferably mesos would use sysconfdir for most (all?) of the things it uses localstatedir for, but that discussion needs to happen elsewhere.)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10912
-----------------------------------------------------------
On Sept. 24, 2012, 2 a.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2012, 2 a.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Debianizing files for Mesos
Posted by Thomas Dudziak <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10912
-----------------------------------------------------------
debian/mesos.mesos-master.upstart
<https://reviews.apache.org/r/2850/#comment23445>
Also, for debian, the mesos configuration should probably be in /etc/mesos ?
- Thomas Dudziak
On June 19, 2012, 10:47 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 10:47 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Debianizing files for Mesos
Posted by Charles Reiss <wo...@gmail.com>.
> On Aug. 30, 2012, 8:34 p.m., Thomas Dudziak wrote:
> > debian/mesos.mesos-master.upstart, line 1
> > <https://reviews.apache.org/r/2850/diff/4/?file=112254#file112254line1>
> >
> > These upstart scripts don't work for several reasons (mesos-daemon uses nohup, but no expect is used in the scripts, the enabled check should be in a pre-start stanza). This is what works for me:
> >
> >
> > description "Mesos Master"
> >
> > env DEFAULTFILE=/etc/default/mesos
> >
> > start on runlevel [2345]
> > respawn
> >
> > pre-start script
> > [ ! -f "$DEFAULTFILE" ] && { stop; exit 0; }
> > enabled=$(grep RUN_MESOS_MASTER=yes $DEFAULTFILE)
> > [ -z "$enabled" ] && { stop; exit 0 }
> > ulimit -n 8192
> > end script
> >
> > script
> > exec /usr/sbin/mesos-master --conf=/var/mesos/conf
> > end script
> >
Done something similar (and for mesos-slave)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10870
-----------------------------------------------------------
On Sept. 24, 2012, 2 a.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2012, 2 a.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Debianizing files for Mesos
Posted by Thomas Dudziak <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10870
-----------------------------------------------------------
debian/mesos.mesos-master.upstart
<https://reviews.apache.org/r/2850/#comment23444>
These upstart scripts don't work for several reasons (mesos-daemon uses nohup, but no expect is used in the scripts, the enabled check should be in a pre-start stanza). This is what works for me:
description "Mesos Master"
env DEFAULTFILE=/etc/default/mesos
start on runlevel [2345]
respawn
pre-start script
[ ! -f "$DEFAULTFILE" ] && { stop; exit 0; }
enabled=$(grep RUN_MESOS_MASTER=yes $DEFAULTFILE)
[ -z "$enabled" ] && { stop; exit 0 }
ulimit -n 8192
end script
script
exec /usr/sbin/mesos-master --conf=/var/mesos/conf
end script
- Thomas Dudziak
On June 19, 2012, 10:47 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 10:47 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>
Re: Review Request: Debianizing files for Mesos
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/
-----------------------------------------------------------
(Updated Sept. 24, 2012, 2 a.m.)
Review request for mesos.
Changes
-------
- don't disable usrlocal check;
- override locatstatedir to /etc for better Debian layout compliance;
- don't use mesos-daemon.sh wrapper from upstart so upstart can manage processes correctly;
Description
-------
This adds files sufficient to build a package for Ubuntu 11.10. Running
./debian/make_snapshot_changelog.sh && debuild -us -uc
should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
Things still to be done to make more generally acceptable Debian packages:
- allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
- package style violations:
- add documentation on how to configure the given startup scripts
- move deploy scripts default config file location to /etc and deploy scripts outside of /var
- add manpages for executables
- fix changelog entries
- support using system versions of third_party libraries, JS libraries
This addresses bug MESOS-74.
https://issues.apache.org/jira/browse/MESOS-74
Diffs (updated)
-----
debian/compat PRE-CREATION
debian/control PRE-CREATION
debian/copyright PRE-CREATION
debian/make_snapshot_changelog.sh PRE-CREATION
debian/mesos.default PRE-CREATION
debian/mesos.mesos-master.upstart PRE-CREATION
debian/mesos.mesos-slave.upstart PRE-CREATION
debian/rules PRE-CREATION
debian/source/format PRE-CREATION
Diff: https://reviews.apache.org/r/2850/diff/
Testing
-------
Thanks,
Charles Reiss
Re: Review Request: Debianizing files for Mesos
Posted by Thomas Dudziak <to...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2850/#review10921
-----------------------------------------------------------
debian/mesos.mesos-master.upstart
<https://reviews.apache.org/r/2850/#comment23457>
Make that
[ -z "$enabled" ] && { stop; exit 0; }
- Thomas Dudziak
On June 19, 2012, 10:47 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2850/
> -----------------------------------------------------------
>
> (Updated June 19, 2012, 10:47 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> This adds files sufficient to build a package for Ubuntu 11.10. Running
>
> ./debian/make_snapshot_changelog.sh && debuild -us -uc
>
> should produce a .deb. It is currently necessary that 'java' and 'javac' be configured (as through update-alternatives) to be OpenJDK 7 for this to work.
>
>
> The resulting package installs Mesos components into /usr, and uses python2.7 and OpenJDK 7. Upstart scripts are installed for mesos-master and mesos-slave along with an /etc/default/mesos to configure whether they run. These scripts invoke the installed mesos-deamon.sh.
>
> Things still to be done to make more generally acceptable Debian packages:
> - allow building against other JDKs and python versions, so this package can be built for other Debian-based distros (at least earlier versions of Ubuntu)
> - package style violations:
> - add documentation on how to configure the given startup scripts
> - move deploy scripts default config file location to /etc and deploy scripts outside of /var
> - add manpages for executables
> - fix changelog entries
> - support using system versions of third_party libraries, JS libraries
>
>
> This addresses bug MESOS-74.
> https://issues.apache.org/jira/browse/MESOS-74
>
>
> Diffs
> -----
>
> debian/compat PRE-CREATION
> debian/control PRE-CREATION
> debian/copyright PRE-CREATION
> debian/make_snapshot_changelog.sh PRE-CREATION
> debian/mesos.default PRE-CREATION
> debian/mesos.mesos-master.upstart PRE-CREATION
> debian/mesos.mesos-slave.upstart PRE-CREATION
> debian/rules PRE-CREATION
> debian/source/format PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>