You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/20 09:07:02 UTC
[GitHub] [mynewt-core] andrzej-kaczmarek opened a new pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
andrzej-kaczmarek opened a new pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394
DMA controller resides in PD_SYS domain so we cannot turn off that
domain if any DMA channes is acquired. That basically means on 1st
acquired DMA channel we need to also acquire PD which we can release
after last DMA channel is released. Note that acquiring PD_SYS means
M33 cannot be powered down in deep sleep.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg commented on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
agross-korg commented on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-713022555
I'm saying that once we fix this we have more work to do to make this power efficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek edited a comment on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek edited a comment on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-713010354
I really do not understand your conclusion here:
- if we disable pd_sys while DMA is active, it will break DMA
- if we do not disable pd_sys while DMA is active, it will increase power consumption
So how exactly do you want to disable pd_sys (decrease power consumption) and keep DMA active (fix instability)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek merged pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek merged pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] agross-korg commented on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
agross-korg commented on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-712928182
I really don't like the overall design of the power management. This patch fixes the issue of instability when we go to deep sleep while the DMA is active. This patch also introduces increased power usage if we happen to go to deep sleep while the DMA is active.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-712707889
@JustineKH ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-712781680
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] andrzej-kaczmarek commented on pull request #2394: hw/mcu/dialog: Acquire PD_SYS for DMA
Posted by GitBox <gi...@apache.org>.
andrzej-kaczmarek commented on pull request #2394:
URL: https://github.com/apache/mynewt-core/pull/2394#issuecomment-713010354
I really do not understand your conclusion here:
- if we disable pd_sys while DMA is active, it will break DMA
- if we do not disable pd_sys while DMA is active, it will increase power consumption
So how exactly do you want to disable pd_sys (decrease power consumption) and keep DMA active (fix instability)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org