[GitHub] [hadoop] virajjasani edited a comment on pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

[GitBox <gi...@apache.org>]

virajjasani edited a comment on pull request #3386:
URL: https://github.com/apache/hadoop/pull/3386#issuecomment-915135845


   Thanks @ayushtkn.
   
   > Just to know, does the Jenkins also complains about this?
   
   Yes, Jenkins does report this e.g https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3359/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
   
   And I also tried to repro on Mac only. It was reproduced one time with single test run (debug mode) but simple rerun is always failing with the same issue.
   
   > Again just asking is there a test-only fix possible, without going to Prod files,
   
   Sure thing, would be happy to fix this by tests only but given how replicas are built up by BlockPoolSlice instance after Datanode is restarted, I think it might be tough to achieve it. At the same time, I am trying to keep source code changes as clear with descriptions as possible to ensure devs understand that a particular flag is for test use only.
   
   FYI @LeonGao91, if you could also review, it would be great. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org