[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #212: cleanup aws and paho extensions

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #212: cleanup aws and paho extensions
URL: https://github.com/apache/camel-quarkus/pull/212#discussion_r329536045
 
 

 ##########
 File path: extensions/aws-eks/deployment/src/main/java/org/apache/camel/quarkus/component/aws/eks/deployment/AwsEKSProcessor.java
 ##########
 @@ -87,8 +77,8 @@ void process(CombinedIndexBuildItem combinedIndexBuildItem,
                 Region.class.getCanonicalName(),
                 Service.class.getCanonicalName(),
                 CredentialScope.class.getCanonicalName(),
-                LogFactoryImpl.class.getCanonicalName(),
-                Jdk14Logger.class.getCanonicalName(),
+                "org.apache.commons.logging.impl.LogFactoryImpl",
+                "org.apache.commons.logging.impl.Jdk14Logger",
 
 Review comment:
   It should not make much difference in this case but having them expressed as literal string does not require to have such classes in the class-path so there is a little bit more freedom about how commons-logging deps are added to the mix.
   
   If you do not like it, I can use classes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services