You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Steve Rowe <sa...@gmail.com> on 2016/11/27 04:29:21 UTC
Re: lucene-solr:master: SOLR-8871 - added suppress forbidden for
toUpperCase usage
Hi Tommaso,
Rather than suppressing the forbidden api failure for the no-arg version of String.toUpperCase(), I think you should be using the version that takes a Locale, e.g.:
algorithmString.toUpperCase(Locale.ROOT);
--
Steve
www.lucidworks.com
> On Nov 24, 2016, at 7:12 PM, tommaso@apache.org wrote:
>
> Repository: lucene-solr
> Updated Branches:
> refs/heads/master 96489d238 -> a4573fe7f
>
>
> SOLR-8871 - added suppress forbidden for toUpperCase usage
>
>
> Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a4573fe7
> Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a4573fe7
> Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a4573fe7
>
> Branch: refs/heads/master
> Commit: a4573fe7f45ba4c84c46d8e7e72c7353164a2696
> Parents: 96489d2
> Author: Tommaso Teofili <to...@apache.org>
> Authored: Fri Nov 25 01:12:03 2016 +0100
> Committer: Tommaso Teofili <to...@apache.org>
> Committed: Fri Nov 25 01:12:03 2016 +0100
>
> ----------------------------------------------------------------------
> .../update/processor/ClassificationUpdateProcessorFactory.java | 2 ++
> 1 file changed, 2 insertions(+)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a4573fe7/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> ----------------------------------------------------------------------
> diff --git a/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java b/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> index 19e0dfe..cbe571b 100644
> --- a/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> +++ b/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> @@ -22,6 +22,7 @@ import org.apache.lucene.search.Query;
> import org.apache.solr.common.SolrException;
> import org.apache.solr.common.params.SolrParams;
> import org.apache.solr.common.util.NamedList;
> +import org.apache.solr.common.util.SuppressForbidden;
> import org.apache.solr.request.SolrQueryRequest;
> import org.apache.solr.response.SolrQueryResponse;
> import org.apache.solr.schema.IndexSchema;
> @@ -59,6 +60,7 @@ public class ClassificationUpdateProcessorFactory extends UpdateRequestProcessor
> private SolrParams params;
> private ClassificationUpdateProcessorParams classificationParams;
>
> + @SuppressForbidden(reason = "Need toUpperCase to match algorithm enum value")
> @Override
> public void init(final NamedList args) {
> if (args != null) {
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: lucene-solr:master: SOLR-8871 - added suppress forbidden for
toUpperCase usage
Posted by Tommaso Teofili <to...@gmail.com>.
thanks Steve for pointing it out, I've fixed it as per your suggestion.
Regards,
Tommaso
Il giorno dom 27 nov 2016 alle ore 05:29 Steve Rowe <sa...@gmail.com> ha
scritto:
> Hi Tommaso,
>
> Rather than suppressing the forbidden api failure for the no-arg version
> of String.toUpperCase(), I think you should be using the version that takes
> a Locale, e.g.:
>
> algorithmString.toUpperCase(Locale.ROOT);
>
> --
> Steve
> www.lucidworks.com
>
> > On Nov 24, 2016, at 7:12 PM, tommaso@apache.org wrote:
> >
> > Repository: lucene-solr
> > Updated Branches:
> > refs/heads/master 96489d238 -> a4573fe7f
> >
> >
> > SOLR-8871 - added suppress forbidden for toUpperCase usage
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/a4573fe7
> > Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/a4573fe7
> > Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/a4573fe7
> >
> > Branch: refs/heads/master
> > Commit: a4573fe7f45ba4c84c46d8e7e72c7353164a2696
> > Parents: 96489d2
> > Author: Tommaso Teofili <to...@apache.org>
> > Authored: Fri Nov 25 01:12:03 2016 +0100
> > Committer: Tommaso Teofili <to...@apache.org>
> > Committed: Fri Nov 25 01:12:03 2016 +0100
> >
> > ----------------------------------------------------------------------
> > .../update/processor/ClassificationUpdateProcessorFactory.java | 2 ++
> > 1 file changed, 2 insertions(+)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/a4573fe7/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> > ----------------------------------------------------------------------
> > diff --git
> a/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> b/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> > index 19e0dfe..cbe571b 100644
> > ---
> a/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> > +++
> b/solr/core/src/java/org/apache/solr/update/processor/ClassificationUpdateProcessorFactory.java
> > @@ -22,6 +22,7 @@ import org.apache.lucene.search.Query;
> > import org.apache.solr.common.SolrException;
> > import org.apache.solr.common.params.SolrParams;
> > import org.apache.solr.common.util.NamedList;
> > +import org.apache.solr.common.util.SuppressForbidden;
> > import org.apache.solr.request.SolrQueryRequest;
> > import org.apache.solr.response.SolrQueryResponse;
> > import org.apache.solr.schema.IndexSchema;
> > @@ -59,6 +60,7 @@ public class ClassificationUpdateProcessorFactory
> extends UpdateRequestProcessor
> > private SolrParams params;
> > private ClassificationUpdateProcessorParams classificationParams;
> >
> > + @SuppressForbidden(reason = "Need toUpperCase to match algorithm enum
> value")
> > @Override
> > public void init(final NamedList args) {
> > if (args != null) {
> >
>
>