[jira] [Comment Edited] (PHOENIX-3263) Allow comma before CONSTRAINT to be optional

["Maryann Xue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487974#comment-15487974 ] 

Maryann Xue edited comment on PHOENIX-3263 at 9/13/16 6:20 PM:
---------------------------------------------------------------

Hey, [~lomoree], in Calcite-Phoenix we are no longer using the original parser code in Phoenix (I believe one of my slides mentioned it). Instead, you should look at files under "phoenix-core/src/main/codegen/", and for this case, specifically at "phoenix-core/src/main/codegen/includes/parserImpls.ftl". These files serve as an extension to the Calcite parser, and you can find all other SQL grammar parsing in the parser files in the Calcite project.


was (Author: maryannxue):
Hey, [~lomoree], in Calcite-Phoenix we are no longer using the original parser code in Phoenix (I believe one of my slides mentioned it). Instead, you should look at files under "phoenix-core/src/main/codegen/", and for this case, specifically at "phoenix-core/src/main/codegen/includes/parserImpls.ftl".

> Allow comma before CONSTRAINT to be optional
> --------------------------------------------
>
>                 Key: PHOENIX-3263
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3263
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>
> In Phoenix, the comma before the CONSTRAINT is optional (which matches Oracle). Can this be supported in Calcite Phoenix?
> For example, this is ok in Phoenix:
> {code}
> CREATE TABLE T (
>     K VARCHAR
>     CONSTRAINT PK PRIMARY KEY (K));
> {code}
> as is this:
> {code}
> CREATE TABLE T (
>     K VARCHAR,
>     CONSTRAINT PK PRIMARY KEY (K));
> {code}
> If this is not feasible, we could require the comma and change the tests. This is leading to a lot of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)