You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/05/01 03:31:03 UTC
[GitHub] [drill] gparai commented on a change in pull request #1775:
DRILL-7227: Fix predicate check in DrillRelOptUtil.analyzeSimpleEquiJoin
gparai commented on a change in pull request #1775: DRILL-7227: Fix predicate check in DrillRelOptUtil.analyzeSimpleEquiJoin
URL: https://github.com/apache/drill/pull/1775#discussion_r279999539
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdDistinctRowCount.java
##########
@@ -180,7 +180,7 @@ private Double getDistinctRowCountInternal(TableScan scan, RelMetadataQuery mq,
}
}
s = Math.min(s, rowCount);
- if (!allCols) {
+ if (s == 1.0 && !allColsHaveNDV) {
Review comment:
`s` is rowcount not selectivity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services