You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/07/31 20:43:47 UTC
[GitHub] [pinot] walterddr opened a new pull request, #11229: Test noop remove
walterddr opened a new pull request, #11229:
URL: https://github.com/apache/pinot/pull/11229
on top of #11205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #11229: [draft][test] no-op removal with yield
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on PR #11229:
URL: https://github.com/apache/pinot/pull/11229#issuecomment-1661096512
closing in favor of new changes in #11205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11229: [draft][test] no-op removal with yield
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11229:
URL: https://github.com/apache/pinot/pull/11229#issuecomment-1659178515
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11229](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7320ded) into [master](https://app.codecov.io/gh/apache/pinot/commit/834c9707e81dc6b40660f6eb0737f5ca3293a2e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (834c970) will **increase** coverage by `0.00%`.
> Report is 5 commits behind head on master.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #11229 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2227 2172 -55
Lines 119628 117035 -2593
Branches 18102 17781 -321
=========================================
Hits 137 137
+ Misses 119471 116878 -2593
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `0.11% <0.00%> (+<0.01%)` | :arrow_up: |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...requesthandler/MultiStageBrokerRequestHandler.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvTXVsdGlTdGFnZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../apache/pinot/common/datablock/DataBlockUtils.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YWJsb2NrL0RhdGFCbG9ja1V0aWxzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...g/apache/pinot/common/datablock/MetadataBlock.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YWJsb2NrL01ldGFkYXRhQmxvY2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...in/java/org/apache/pinot/core/common/Operator.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vT3BlcmF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...apache/pinot/query/mailbox/GrpcSendingMailbox.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvbWFpbGJveC9HcnBjU2VuZGluZ01haWxib3guamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...g/apache/pinot/query/mailbox/ReceivingMailbox.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvbWFpbGJveC9SZWNlaXZpbmdNYWlsYm94LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...rg/apache/pinot/query/runtime/OpChainExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9PcENoYWluRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...va/org/apache/pinot/query/runtime/QueryRunner.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9RdWVyeVJ1bm5lci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../pinot/query/runtime/blocks/TransferableBlock.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9ibG9ja3MvVHJhbnNmZXJhYmxlQmxvY2suamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...t/query/runtime/blocks/TransferableBlockUtils.java](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtcXVlcnktcnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvcXVlcnkvcnVudGltZS9ibG9ja3MvVHJhbnNmZXJhYmxlQmxvY2tVdGlscy5qYXZh) | `0.00% <ø> (ø)` | |
| ... and [21 more](https://app.codecov.io/gh/apache/pinot/pull/11229?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [64 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11229/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] gortiz commented on a diff in pull request #11229: [draft][test] no-op removal with yield
Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz commented on code in PR #11229:
URL: https://github.com/apache/pinot/pull/11229#discussion_r1280181355
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerOperator.java:
##########
@@ -70,14 +71,52 @@ public String toExplainString() {
@Override
protected TransferableBlock getNextBlock() {
- Pair<Integer, TransferableBlock> pair = _blockConsumer.readBlockBlocking();
- TransferableBlock block = pair.getRight();
- if (block.isDataBlock()) {
- _resultMap.get(pair.getLeft()).add(block);
- return block;
- } else if (block.isErrorBlock()) {
- constructErrorResponse(block);
- return block;
+ while (!_workerEntries.isEmpty()) {
+ if (_errorBlock != null) {
+ return _errorBlock;
+ }
+ if (System.currentTimeMillis() > _context.getDeadlineMs()) {
+ _errorBlock = TransferableBlockUtils.getErrorTransferableBlock(QueryException.EXECUTION_TIMEOUT_ERROR);
+ constructErrorResponse(_errorBlock);
+ return _errorBlock;
+ }
+
+ // Poll from every mailbox operator in round-robin fashion:
+ // - Return the first content block
+ // - If no content block found but there are mailboxes not finished, return no-op block
+ // - If all content blocks are already returned, return end-of-stream block
+ int numWorkers = _workerEntries.size();
+ for (int i = 0; i < numWorkers; i++) {
+ Map.Entry<Integer, Operator<TransferableBlock>> worker = _workerEntries.remove();
+ TransferableBlock block = worker.getValue().nextBlock();
Review Comment:
This is correct, but here we are blocking on the first operators on the queue even if other elements have data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #11229: [draft][test] no-op removal with yield
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on code in PR #11229:
URL: https://github.com/apache/pinot/pull/11229#discussion_r1280702116
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/pipeline/PipelineBreakerOperator.java:
##########
@@ -70,14 +71,52 @@ public String toExplainString() {
@Override
protected TransferableBlock getNextBlock() {
- Pair<Integer, TransferableBlock> pair = _blockConsumer.readBlockBlocking();
- TransferableBlock block = pair.getRight();
- if (block.isDataBlock()) {
- _resultMap.get(pair.getLeft()).add(block);
- return block;
- } else if (block.isErrorBlock()) {
- constructErrorResponse(block);
- return block;
+ while (!_workerEntries.isEmpty()) {
+ if (_errorBlock != null) {
+ return _errorBlock;
+ }
+ if (System.currentTimeMillis() > _context.getDeadlineMs()) {
+ _errorBlock = TransferableBlockUtils.getErrorTransferableBlock(QueryException.EXECUTION_TIMEOUT_ERROR);
+ constructErrorResponse(_errorBlock);
+ return _errorBlock;
+ }
+
+ // Poll from every mailbox operator in round-robin fashion:
+ // - Return the first content block
+ // - If no content block found but there are mailboxes not finished, return no-op block
+ // - If all content blocks are already returned, return end-of-stream block
+ int numWorkers = _workerEntries.size();
+ for (int i = 0; i < numWorkers; i++) {
+ Map.Entry<Integer, Operator<TransferableBlock>> worker = _workerEntries.remove();
+ TransferableBlock block = worker.getValue().nextBlock();
Review Comment:
yes. currently the pipeline breaker behavior is blocking thus i cannot process the main opChain until all mailboxes are received anyway. i think this is fair for now but optimization can be done later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr closed pull request #11229: [draft][test] no-op removal with yield
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed pull request #11229: [draft][test] no-op removal with yield
URL: https://github.com/apache/pinot/pull/11229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org