You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/05 20:04:23 UTC

[GitHub] [arrow] wjones127 commented on a diff in pull request #13520: [WIP] ARROW-14889: [C++] GCS tests hang if testbench not installed

wjones127 commented on code in PR #13520:
URL: https://github.com/apache/arrow/pull/13520#discussion_r914161355


##########
cpp/src/arrow/filesystem/gcsfs_test.cc:
##########
@@ -278,7 +288,8 @@ class GcsIntegrationTest : public ::testing::Test {
 class TestGCSFSGeneric : public GcsIntegrationTest, public GenericFileSystemTest {
  public:
   void SetUp() override {
-    GcsIntegrationTest::SetUp();
+    GcsIntegrationTest::SetUp(); // Setup failure is not propagating
+    ASSERT_TRUE(Testbench()->running());

Review Comment:
   One problem is the `SetUp()` assertion failures are not propagating to the child. The method just exits early and then the outer `SetUp()` continues as normal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org