You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/07/16 10:55:36 UTC
[GitHub] [activemq-nms-amqp] lukeabsent opened a new pull request #69: AMQNET-722 Connection timing new options
lukeabsent opened a new pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#discussion_r682438379
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is 0 which means unlimited.
Review comment:
e.g. - **failover.maxReconnectAttempts** The number of reconnection attempts allowed before reporting the connection as failed to the client. The default is no limit or (-1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] lukeabsent commented on a change in pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
lukeabsent commented on a change in pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#discussion_r683250137
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is 0 which means unlimited.
Review comment:
ok, makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#issuecomment-887849182
rebase instead of merge, to avoid merge commits in your local fork/branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce merged pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
michaelandrepearce merged pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] lukeabsent commented on a change in pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
lukeabsent commented on a change in pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#discussion_r683250137
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is 0 which means unlimited.
Review comment:
ok, makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#discussion_r682437870
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is 0 which means unlimited.
Review comment:
typically -1 means to disable/no limit, can we align please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #69: AMQNET-722 Connection timing new options
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on a change in pull request #69:
URL: https://github.com/apache/activemq-nms-amqp/pull/69#discussion_r682437870
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxNewConnectionRatePerSec** Allowed approximated rate for how fast connection factory is allowed to create new connection. If there is more request, they will have to wait. Default value is 0 which means unlimited.
Review comment:
typically -1 means to disable/no limit, can we align and use -1 please as default and have this mean this feature is disabled/no limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org