[GitHub] [ozone] rakeshadr commented on a change in pull request #2819: HDDS-5929. Make FSO and OBS bucket layouts independent of normalization config flag

[GitBox <gi...@apache.org>]

rakeshadr commented on a change in pull request #2819:
URL: https://github.com/apache/ozone/pull/2819#discussion_r746259819



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -78,6 +80,29 @@ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
     Preconditions.checkNotNull(allocateBlockRequest);
 
     KeyArgs keyArgs = allocateBlockRequest.getKeyArgs();
+    String keyPath = keyArgs.getKeyName();
+    BucketLayout bucketLayout = getBucketLayout();
+    LOG.info("Bucket Layout: " + bucketLayout);

Review comment:
       Please change the priority to DEBUG and do like,
   
   `LOG.debug("Bucket Layout: {}", bucketLayout);`

##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##########
@@ -78,6 +80,29 @@ public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
     Preconditions.checkNotNull(allocateBlockRequest);
 
     KeyArgs keyArgs = allocateBlockRequest.getKeyArgs();
+    String keyPath = keyArgs.getKeyName();

Review comment:
       This functionality has duplicated over all the requests. Can you move this to OmClientRequest.java
   
   `String OmClientRequest#validateAndNormalizeKey(BucketLayout bucketLayout, String keyPath, OzoneManager ozoneManager) throws OMException `
   
   and we can use this method in the OM request classes.
   
   `String keyPath = validateAndNormalizeKey(getBucketLayout(), keyArgs.getKeyName(), ozoneManager);`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org