You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Dirk Frederickx <di...@gmail.com> on 2018/07/01 14:24:03 UTC
Re: [apache/jspwiki] Clickable buttons (#1)
All,
Please checkout 2.10.5-git-05 for some updates related to tablet/phone
support.
dirk
On Sun, Jun 24, 2018 at 12:25 PM Juan Pablo Santos Rodríguez <
juanpablo.santos@gmail.com> wrote:
> Hi Dirk,
>
> re. click on button / links on login area: yup , login area == the dropdown
> menu of the user-box in the right-top
> of the screen; also happens with the search dropdown. It does not happen
> with the rest of buttons/links on next
> row (left-menu, breadcrumbs, info, more items, etc), though.
>
> re. info button: +1 to a separate button
>
>
> thx + br,
> juan pablo
>
> On Sun, Jun 24, 2018 at 10:45 AM, Dirk Frederickx <
> dirk.frederickx@gmail.com
> > wrote:
>
> > Hi Juan,
> >
> > Txs.
> >
> > *>>> - I'm unable to click on button / links on login area. More
> > precisely, Iclick on them but nothing happens, the menu just goes out.*
> > "Login Area" is the dropdown menu of the user-box in the right-top of the
> > screen; or are you referring to the main Login.jsp screen itself?
> > Do you have the same issue with the "Full Search" button in the search
> > dropdown ?
> >
> > >>> - the info clickable button shows the associated menu, but redirects
> > to Info page soon afterwards. On desktop, the info tab is hoverable and
> > shows a menu, and when you click on it you go to the info page, so it's
> > probably that behaviour combined with the clickable buttons
> > I think this is a confusing UI : the "INFO" button actually mixes 2
> > behaviors but that's not working on touch devices.
> > I'll probably add a button to the info dropdown menu to get you to the
> info
> > page.
> >
> >
> >
> > On Thu, Jun 21, 2018 at 9:07 PM Juan Pablo Santos Rodríguez <
> > juanpablo.santos@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > not too much free time lately, but I've pushed an snapshot to
> > > repository.a.o [#1], so there are binaries available for testing from
> > > there.
> > >
> > > regarding hover/clickable buttons, I do like *very* much the "swinging"
> > > effect on icons :-) The new breadcrumbs area is also cleaner when
> you've
> > > navigated some pages. The haddock template keeps getting better! I've
> > > noticed a couple of glitches when on mobile, though (S8, with both
> chrome
> > > and free adblock browser):
> > > - I'm unable to click on button / links on login area. More precisely,
> I
> > > click on them but nothing happens, the menu just goes out.
> > > - the info clickable button shows the associated menu, but redirects to
> > > Info page soon afterwards. On desktop, the info tab is hoverable and
> > shows
> > > a menu, and when you click on it you go to the info page, so it's
> > probably
> > > that behaviour combined with the clickable buttons
> > >
> > > as for the PR, I'm not sure I'm understanding, is it that you are not
> > able
> > > to close it (the button isn't there)? if not that, closing it with a
> > > comment along the lines of "thanks for your contribution, as this
> > > functionality has been included as of last commit, we're closing this
> PR.
> > > Please do keep sending whatever improvements you see fit"? (btw,
> > @jonasmue
> > > are you on this list? I bet you probably are..) WDYT?
> > >
> > >
> > > br,
> > > juan pablo
> > >
> > > [#1]:
> > >
> > > https://repository.apache.org/#nexus-search;gav~org.apache.
> > jspwiki~~2.10.5-SNAPSHOT~~
> > >
> > > On Thu, Jun 21, 2018 at 7:42 AM, Harry Metske <ha...@gmail.com>
> > > wrote:
> > >
> > > > done
> > > >
> > > > regards,
> > > > Harry
> > > >
> > > >
> > > > On Wed, 20 Jun 2018 at 19:40, Dirk Frederickx <
> > dirk.frederickx@gmail.com
> > > >
> > > > wrote:
> > > >
> > > > > Harry, Juan,
> > > > >
> > > > > I made a commit earlier this week to resolve the hover/clickable
> > > buttons
> > > > > for devices with a touch-interface.
> > > > > Would it be possible to push the update to jspwiki-wiki.apache.org
> .
> > > > > Testing was done on iPad/iPhone, but I'd like to get feedback on
> > other
> > > > > types of touch devices.
> > > > >
> > > > >
> > > > > Not sure how to close the issue on github.
> > > > >
> > > > >
> > > > > br,
> > > > > dirk
> > > > >
> > > > >
> > > > >
> > > > > On Tue, May 29, 2018 at 6:45 PM Harry Metske <
> harry.metske@gmail.com
> > >
> > > > > wrote:
> > > > >
> > > > > > I had seen it before on the dev list.
> > > > > > But since it was mostly frontend, I did not comment.
> > > > > >
> > > > > > cheers,
> > > > > > Harry
> > > > > >
> > > > > >
> > > > > > On Tue, 29 May 2018 at 00:40, Juan Pablo Santos Rodríguez <
> > > > > > juanpablo.santos@gmail.com> wrote:
> > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > I was looking for the below mail at
> [user|dev|commits]@jspwiki.a.
> > o.
> > > > As
> > > > > I
> > > > > > > can't see it through Pony Mail, I'm resending over
> > > > > > > dev. Would anyone mind confirming if this is the first time
> > > receiving
> > > > > the
> > > > > > > e-mail? (if not, apologies for the noise).
> > > > > > >
> > > > > > > And regarding the PR itself, any thoughts on it? I find it
> > useful,
> > > > esp.
> > > > > > for
> > > > > > > mobile devices, and would be +1 for merging it,
> > > > > > > but I don't have a strong opinion on it, frontend isn't one of
> my
> > > key
> > > > > > > points..
> > > > > > >
> > > > > > >
> > > > > > > thanks in advance,
> > > > > > > juan pablo
> > > > > > >
> > > > > > >
> > > > > > > ---------- Forwarded message ----------
> > > > > > > From: jonasmue <no...@github.com>
> > > > > > > Date: Fri, May 25, 2018 at 1:35 PM
> > > > > > > Subject: [apache/jspwiki] Clickable buttons (#1)
> > > > > > > To: apache/jspwiki <js...@noreply.github.com>
> > > > > > > Cc: Subscribed <su...@noreply.github.com>
> > > > > > >
> > > > > > >
> > > > > > > Made header buttons clickable instead of hoverable. This change
> > > > should
> > > > > > > result in increased usability since the opening boxes
> frequently
> > > > would
> > > > > > have
> > > > > > > been closed involuntarily if user's mouse movement was not
> > precise
> > > > > enough
> > > > > > > after hovering over the buttons. Removed the carets for
> > consistency
> > > > > > reasons
> > > > > > > as they indicate a hoverable target.
> > > > > > > ------------------------------
> > > > > > > You can view, comment on, or merge this pull request online at:
> > > > > > >
> > > > > > > https://github.com/apache/jspwiki/pull/1
> > > > > > > Commit Summary
> > > > > > >
> > > > > > > - Clickable header buttons
> > > > > > > - Updated to current state and removed other changes
> > > > > > > - Changed indentation to original form
> > > > > > >
> > > > > > > File Changes
> > > > > > >
> > > > > > > - *M* jspwiki-war/src/main/scripts/wiki/Wiki.js
> > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-0>
> (35)
> > > > > > > - *M*
> > > jspwiki-war/src/main/webapp/templates/haddock/SearchBox.jsp
> > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-1> (4)
> > > > > > > - *M* jspwiki-war/src/main/webapp/
> > templates/haddock/UserBox.jsp
> > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-2> (4)
> > > > > > >
> > > > > > > Patch Links:
> > > > > > >
> > > > > > > - https://github.com/apache/jspwiki/pull/1.patch
> > > > > > > - https://github.com/apache/jspwiki/pull/1.diff
> > > > > > >
> > > > > > > —
> > > > > > > You are receiving this because you are subscribed to this
> thread.
> > > > > > > Reply to this email directly, view it on GitHub
> > > > > > > <https://github.com/apache/jspwiki/pull/1>, or mute the thread
> > > > > > > <
> > > > > > >
> > > > > >
> > > > > https://github.com/notifications/unsubscribe-auth/
> > > > ABKX4v23eYQ0kCinSJj1cWhts1HVqYbUks5t1-yBgaJpZM4UN0uj
> > > > > > > >
> > > > > > > .
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
Re: [apache/jspwiki] Clickable buttons (#1)
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,
I've uploaded an snapshot to repository.a.o earlier today with those
changes, I'll give it a try this week.
thx!
On Sun, Jul 1, 2018 at 4:24 PM, Dirk Frederickx <di...@gmail.com>
wrote:
> All,
>
> Please checkout 2.10.5-git-05 for some updates related to tablet/phone
> support.
>
> dirk
>
> On Sun, Jun 24, 2018 at 12:25 PM Juan Pablo Santos Rodríguez <
> juanpablo.santos@gmail.com> wrote:
>
> > Hi Dirk,
> >
> > re. click on button / links on login area: yup , login area == the
> dropdown
> > menu of the user-box in the right-top
> > of the screen; also happens with the search dropdown. It does not happen
> > with the rest of buttons/links on next
> > row (left-menu, breadcrumbs, info, more items, etc), though.
> >
> > re. info button: +1 to a separate button
> >
> >
> > thx + br,
> > juan pablo
> >
> > On Sun, Jun 24, 2018 at 10:45 AM, Dirk Frederickx <
> > dirk.frederickx@gmail.com
> > > wrote:
> >
> > > Hi Juan,
> > >
> > > Txs.
> > >
> > > *>>> - I'm unable to click on button / links on login area. More
> > > precisely, Iclick on them but nothing happens, the menu just goes out.*
> > > "Login Area" is the dropdown menu of the user-box in the right-top of
> the
> > > screen; or are you referring to the main Login.jsp screen itself?
> > > Do you have the same issue with the "Full Search" button in the search
> > > dropdown ?
> > >
> > > >>> - the info clickable button shows the associated menu, but
> redirects
> > > to Info page soon afterwards. On desktop, the info tab is hoverable and
> > > shows a menu, and when you click on it you go to the info page, so it's
> > > probably that behaviour combined with the clickable buttons
> > > I think this is a confusing UI : the "INFO" button actually mixes 2
> > > behaviors but that's not working on touch devices.
> > > I'll probably add a button to the info dropdown menu to get you to the
> > info
> > > page.
> > >
> > >
> > >
> > > On Thu, Jun 21, 2018 at 9:07 PM Juan Pablo Santos Rodríguez <
> > > juanpablo.santos@gmail.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > not too much free time lately, but I've pushed an snapshot to
> > > > repository.a.o [#1], so there are binaries available for testing from
> > > > there.
> > > >
> > > > regarding hover/clickable buttons, I do like *very* much the
> "swinging"
> > > > effect on icons :-) The new breadcrumbs area is also cleaner when
> > you've
> > > > navigated some pages. The haddock template keeps getting better! I've
> > > > noticed a couple of glitches when on mobile, though (S8, with both
> > chrome
> > > > and free adblock browser):
> > > > - I'm unable to click on button / links on login area. More
> precisely,
> > I
> > > > click on them but nothing happens, the menu just goes out.
> > > > - the info clickable button shows the associated menu, but redirects
> to
> > > > Info page soon afterwards. On desktop, the info tab is hoverable and
> > > shows
> > > > a menu, and when you click on it you go to the info page, so it's
> > > probably
> > > > that behaviour combined with the clickable buttons
> > > >
> > > > as for the PR, I'm not sure I'm understanding, is it that you are not
> > > able
> > > > to close it (the button isn't there)? if not that, closing it with a
> > > > comment along the lines of "thanks for your contribution, as this
> > > > functionality has been included as of last commit, we're closing this
> > PR.
> > > > Please do keep sending whatever improvements you see fit"? (btw,
> > > @jonasmue
> > > > are you on this list? I bet you probably are..) WDYT?
> > > >
> > > >
> > > > br,
> > > > juan pablo
> > > >
> > > > [#1]:
> > > >
> > > > https://repository.apache.org/#nexus-search;gav~org.apache.
> > > jspwiki~~2.10.5-SNAPSHOT~~
> > > >
> > > > On Thu, Jun 21, 2018 at 7:42 AM, Harry Metske <
> harry.metske@gmail.com>
> > > > wrote:
> > > >
> > > > > done
> > > > >
> > > > > regards,
> > > > > Harry
> > > > >
> > > > >
> > > > > On Wed, 20 Jun 2018 at 19:40, Dirk Frederickx <
> > > dirk.frederickx@gmail.com
> > > > >
> > > > > wrote:
> > > > >
> > > > > > Harry, Juan,
> > > > > >
> > > > > > I made a commit earlier this week to resolve the hover/clickable
> > > > buttons
> > > > > > for devices with a touch-interface.
> > > > > > Would it be possible to push the update to
> jspwiki-wiki.apache.org
> > .
> > > > > > Testing was done on iPad/iPhone, but I'd like to get feedback on
> > > other
> > > > > > types of touch devices.
> > > > > >
> > > > > >
> > > > > > Not sure how to close the issue on github.
> > > > > >
> > > > > >
> > > > > > br,
> > > > > > dirk
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Tue, May 29, 2018 at 6:45 PM Harry Metske <
> > harry.metske@gmail.com
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > I had seen it before on the dev list.
> > > > > > > But since it was mostly frontend, I did not comment.
> > > > > > >
> > > > > > > cheers,
> > > > > > > Harry
> > > > > > >
> > > > > > >
> > > > > > > On Tue, 29 May 2018 at 00:40, Juan Pablo Santos Rodríguez <
> > > > > > > juanpablo.santos@gmail.com> wrote:
> > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > I was looking for the below mail at
> > [user|dev|commits]@jspwiki.a.
> > > o.
> > > > > As
> > > > > > I
> > > > > > > > can't see it through Pony Mail, I'm resending over
> > > > > > > > dev. Would anyone mind confirming if this is the first time
> > > > receiving
> > > > > > the
> > > > > > > > e-mail? (if not, apologies for the noise).
> > > > > > > >
> > > > > > > > And regarding the PR itself, any thoughts on it? I find it
> > > useful,
> > > > > esp.
> > > > > > > for
> > > > > > > > mobile devices, and would be +1 for merging it,
> > > > > > > > but I don't have a strong opinion on it, frontend isn't one
> of
> > my
> > > > key
> > > > > > > > points..
> > > > > > > >
> > > > > > > >
> > > > > > > > thanks in advance,
> > > > > > > > juan pablo
> > > > > > > >
> > > > > > > >
> > > > > > > > ---------- Forwarded message ----------
> > > > > > > > From: jonasmue <no...@github.com>
> > > > > > > > Date: Fri, May 25, 2018 at 1:35 PM
> > > > > > > > Subject: [apache/jspwiki] Clickable buttons (#1)
> > > > > > > > To: apache/jspwiki <js...@noreply.github.com>
> > > > > > > > Cc: Subscribed <su...@noreply.github.com>
> > > > > > > >
> > > > > > > >
> > > > > > > > Made header buttons clickable instead of hoverable. This
> change
> > > > > should
> > > > > > > > result in increased usability since the opening boxes
> > frequently
> > > > > would
> > > > > > > have
> > > > > > > > been closed involuntarily if user's mouse movement was not
> > > precise
> > > > > > enough
> > > > > > > > after hovering over the buttons. Removed the carets for
> > > consistency
> > > > > > > reasons
> > > > > > > > as they indicate a hoverable target.
> > > > > > > > ------------------------------
> > > > > > > > You can view, comment on, or merge this pull request online
> at:
> > > > > > > >
> > > > > > > > https://github.com/apache/jspwiki/pull/1
> > > > > > > > Commit Summary
> > > > > > > >
> > > > > > > > - Clickable header buttons
> > > > > > > > - Updated to current state and removed other changes
> > > > > > > > - Changed indentation to original form
> > > > > > > >
> > > > > > > > File Changes
> > > > > > > >
> > > > > > > > - *M* jspwiki-war/src/main/scripts/wiki/Wiki.js
> > > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-0>
> > (35)
> > > > > > > > - *M*
> > > > jspwiki-war/src/main/webapp/templates/haddock/SearchBox.jsp
> > > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-1>
> (4)
> > > > > > > > - *M* jspwiki-war/src/main/webapp/
> > > templates/haddock/UserBox.jsp
> > > > > > > > <https://github.com/apache/jspwiki/pull/1/files#diff-2>
> (4)
> > > > > > > >
> > > > > > > > Patch Links:
> > > > > > > >
> > > > > > > > - https://github.com/apache/jspwiki/pull/1.patch
> > > > > > > > - https://github.com/apache/jspwiki/pull/1.diff
> > > > > > > >
> > > > > > > > —
> > > > > > > > You are receiving this because you are subscribed to this
> > thread.
> > > > > > > > Reply to this email directly, view it on GitHub
> > > > > > > > <https://github.com/apache/jspwiki/pull/1>, or mute the
> thread
> > > > > > > > <
> > > > > > > >
> > > > > > >
> > > > > > https://github.com/notifications/unsubscribe-auth/
> > > > > ABKX4v23eYQ0kCinSJj1cWhts1HVqYbUks5t1-yBgaJpZM4UN0uj
> > > > > > > > >
> > > > > > > > .
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>