You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/20 12:06:47 UTC

[GitHub] [flink] anonymouscodeholic commented on pull request #13688: Arena block size sanity

anonymouscodeholic commented on pull request #13688:
URL: https://github.com/apache/flink/pull/13688#issuecomment-712802434


   > Some quick comments:
   > 
   > It seems the [comments](https://github.com/apache/flink/pull/13393#discussion_r502241882) on the javadoc of `RocksDBMemoryControllerUtils` (fix on the link style) were neglected, could you double check it @anonymouscodeholic ?
   > 
   > And maybe also the [comment](https://github.com/apache/flink/pull/13393#discussion_r502243922) on `RocksDBOperationsUtilsTest`, which I think could make the test case more readable.
   > 
   > Thanks.
   
   Hey, things got complicated, because I couldn't approve the changes in the original PR and had to hand-pick them in this PR. I think I just missed those few comments. 
   
   Just pushed the latest.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org