You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/21 19:31:45 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #8496: List of integrations is now maintained in one place.

kaxil commented on a change in pull request #8496:
URL: https://github.com/apache/airflow/pull/8496#discussion_r412434183



##########
File path: scripts/ci/_utils.sh
##########
@@ -60,6 +60,8 @@ function initialize_common_environment {
     mkdir -p "${AIRFLOW_SOURCES}/files"
     mkdir -p "${AIRFLOW_SOURCES}/dist"
 
+    # shellcheck source=common/_common_values.sh
+    . "${AIRFLOW_SOURCES}/common/_common_values.sh"

Review comment:
       A query (not an issue), can/should we merge all the "common" values in a single script?
   
   - `. "${AIRFLOW_SOURCES}/common/_common_values.sh"`
   - `. "${AIRFLOW_SOURCES}/common/_image_variables.sh"`
   - `. "${AIRFLOW_SOURCES}/common/_files_for_rebuild_check.sh"`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org