[jira] [Commented] (ARTEMIS-1335) Update Netty to 4.1.14

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119872#comment-16119872 ] 

ASF GitHub Bot commented on ARTEMIS-1335:
-----------------------------------------

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1452#discussion_r132177518
  
    --- Diff: artemis-journal/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBufWrapper.java ---
    @@ -563,7 +564,11 @@ protected SwappedByteBuf newSwappedByteBuf() {
        @Override
        public ByteBuf setZero(int index, int length) {
           if (hasMemoryAddress()) {
    -         UnsafeByteBufUtil.setZero(this, addr(index), index, length);
    +         if (length == 0) {
    --- End diff --
    
    We have to do this as UnsafeByteBufUtil.setZero(this, addr(index), index, length); util method is removed in 4.1.14 this was the underlying util logic.



> Update Netty to 4.1.14
> ----------------------
>
>                 Key: ARTEMIS-1335
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1335
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Michael Andre Pearce
>
> Netty just released a bunch of improvements and bug fixes in 4.1.14 especially around epoll native, which we should look to take advantage of.
> Also to note recent update of qpid-jms and jproton are dependent on 4.1.14 also.
> As such its prudent to update artemis dependency to 4.1.14.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)