You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/28 08:45:21 UTC
[GitHub] [flink] zentol commented on a diff in pull request #20911: [FLINK-29436][build] Upgrade spotless for running on JDK 17
zentol commented on code in PR #20911:
URL: https://github.com/apache/flink/pull/20911#discussion_r982123131
##########
pom.xml:
##########
@@ -1018,30 +1018,6 @@ under the License.
</build>
</profile>
- <profile>
- <id>java17</id>
- <activation>
- <jdk>[17,)</jdk>
- </activation>
-
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>com.diffplug.spotless</groupId>
- <artifactId>spotless-maven-plugin</artifactId>
- <configuration>
- <!-- Current google format does not run on Java 17.
- Don't upgrade it in this profile because it formats code differently.
Review Comment:
It...kinda means what it says.
The google java format we use (1.7; _not the spotless version_), does not run on Java 17.
Newer versions that do run format things slightly differently w.r.t. lambdas, but IIRC no longer run on Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org