You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/27 15:11:35 UTC

[GitHub] [beam] mosche commented on a diff in pull request #22473: WIP: Support TestStream for Spark runner in streaming mode (#22472).

mosche commented on code in PR #22473:
URL: https://github.com/apache/beam/pull/22473#discussion_r931186776


##########
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkRunner.java:
##########
@@ -453,7 +454,9 @@ TransformEvaluator<TransformT> translate(
       } else {
         pValues = node.getInputs();
       }
-      PCollection.IsBounded isNodeBounded = isBoundedCollection(pValues.values());
+      // FIXME Why is the output of TestSparkRunner.UnboundedReadFromBoundedSourceOverrideFactory BOUNDED!?!

Review Comment:
   @aromanenko-dev @echauchot A bit stuck here.... Wondering if you have any idea what the issue is, see the replacement below. It replaces a bounded read with an unbounded read so validates runner tests using `Create.of(...)` can be run in streaming mode.
   
   However, `isBounded` of the output still returns `BOUNDED` 🤯 
   
   https://github.com/apache/beam/pull/22473/files#diff-d81f49eb0330230bd03ce6cd33b5f70f59c443aac57741e877ececbada32b16bR112-R117



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org