[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1239: [CELEBORN-302] Fix workers count out of sync in HA mode.

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1239:
URL: https://github.com/apache/incubator-celeborn/pull/1239#discussion_r1106768628


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -51,7 +47,7 @@ public abstract class AbstractMetaManager implements IMetadataHandler {
   // Meta data for master service
   public final Set<String> registeredShuffle = ConcurrentHashMap.newKeySet();
   public final Set<String> hostnameSet = ConcurrentHashMap.newKeySet();
-  public final ArrayList<WorkerInfo> workers = new ArrayList<>();
+  public final Set<WorkerInfo> workers = new HashSet<>();

Review Comment:
   The implementation of `WorkerInfo#equals` is fragile, e.g. what if the `obj` is not a `WorkerInfo` object?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org