[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

[GitBox <gi...@apache.org>]

kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions
URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317891752
 
 

 ##########
 File path: be/src/olap/rowset/segment_v2/segment_iterator.h
 ##########
 @@ -49,16 +49,19 @@ class SegmentIterator : public RowwiseIterator {
     Status next_batch(RowBlockV2* row_block) override;
     const Schema& schema() const override { return _schema; }
 private:
-    Status _init_short_key_range();
-    Status _prepare_seek();
-    Status _init_row_ranges();
-    Status _get_row_ranges_from_zone_map(RowRanges* zone_map_row_ranges);
-    Status _init_column_iterators();
-    Status _create_column_iterator(uint32_t cid, ColumnIterator** iter);
-
+    // calculate row ranges that fall into requested key ranges using short key index
+    Status _get_row_ranges_by_keys();
+    Status _prepare_seek(const StorageReadOptions::KeyRange& key_range);
     Status _lookup_ordinal(const RowCursor& key, bool is_include,
                            rowid_t upper_bound, rowid_t* rowid);
     Status _seek_and_peek(rowid_t rowid);
+
+    // calculate row ranges that satisfy requested column conditions using various column index
+    Status _get_row_ranges_by_column_conditions();
+    Status _get_row_ranges_from_zone_map(RowRanges* zone_map_row_ranges);
 
 Review comment:
   add a get_row_ranges_by_conditions function to column_reader and move this function to column_reader.
   so column reader will care about all the indexes processing including zone map/bf/bitmap.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org