You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2017/03/16 23:37:25 UTC
[GitHub] cordova-ios pull request #298: CB-12577 - Fix module import warnings when us...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/298
CB-12577 - Fix module import warnings when using Cordova.framework (Carthage)
### Platforms affected
self
### What does this PR do?
Remove warnings related to incomplete umbrella headers when using `@import Cordova` after compiling Cordova.framework using Carthage.
### What testing has been done on this change?
Added Cordova.framework from the repo using Carthage, added the import, added a reference to CDVViewController, and built an iOS View app.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-12577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit c7b422c5bd7a45e37df5945ca336bab58a1263a2
Author: Shazron Abdullah <sh...@gmail.com>
Date: 2017-03-16T23:35:02Z
CB-12577 - Fix module import warnings when using Cordova.framework (Carthage)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #298: CB-12577 - Fix module import warnings when us...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/298
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #298: CB-12577 - Fix module import warnings when using Cor...
Posted by khawkins <gi...@git.apache.org>.
Github user khawkins commented on the issue:
https://github.com/apache/cordova-ios/pull/298
Thanks @shazron . I could have sworn those were in there initially, but I guess not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org