You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/21 06:09:35 UTC

[GitHub] [flink] JingsongLi commented on pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

JingsongLi commented on pull request #18412:
URL: https://github.com/apache/flink/pull/18412#issuecomment-1018210567


   Thanks @fapaul for the review, I've rethought it and it's probably not a good idea either way.
   - approach 1: `SinkWriter` implements `MetadataPublisher`, actually, `subscribe` method should be similar to `open`, before other calls. Otherwise, there are thread safety issues. But the thing is, `SinkWriter` dose not have `open`. It is opened in `Sink.createWriter`.
   - approach 2: `Sink` implements `MetadataPublisher`, the question is when to call `subscribe`? On the client side or the server side? What about the serialization call on the client side, does the `Consumer` still work properly after serialization?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org