[GitHub] [arrow-adbc] paleolimbot commented on a diff in pull request #417: format(api!): clarify const-ness of some pointers

["paleolimbot (via GitHub)" <gi...@apache.org>]

paleolimbot commented on code in PR #417:
URL: https://github.com/apache/arrow-adbc/pull/417#discussion_r1096868839


##########
adbc.h:
##########
@@ -729,7 +729,8 @@ AdbcStatusCode AdbcConnectionSetOption(struct AdbcConnection* connection, const
 /// as well.
 ADBC_EXPORT
 AdbcStatusCode AdbcConnectionInit(struct AdbcConnection* connection,
-                                  struct AdbcDatabase* database, struct AdbcError* error);
+                                  const struct AdbcDatabase* database,

Review Comment:
   It seems like it should be able to modify the database if it needs to? (For example, the database private member might contain a counter to count open connections, and this could increment it by one?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org