You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ps...@apache.org on 2015/05/29 16:40:50 UTC

svn commit: r1682491 - in /commons/proper/pool/trunk: RELEASE-NOTES.txt findbugs-exclude-filter.xml src/changes/changes.xml

Author: psteitz
Date: Fri May 29 14:40:50 2015
New Revision: 1682491

URL: http://svn.apache.org/r1682491
Log:
Mute findbugs false positives.

Modified:
    commons/proper/pool/trunk/RELEASE-NOTES.txt
    commons/proper/pool/trunk/findbugs-exclude-filter.xml
    commons/proper/pool/trunk/src/changes/changes.xml

Modified: commons/proper/pool/trunk/RELEASE-NOTES.txt
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/RELEASE-NOTES.txt?rev=1682491&r1=1682490&r2=1682491&view=diff
==============================================================================
--- commons/proper/pool/trunk/RELEASE-NOTES.txt (original)
+++ commons/proper/pool/trunk/RELEASE-NOTES.txt Fri May 29 14:40:50 2015
@@ -19,8 +19,8 @@ NOTE: The MBean interfaces (DefaultPoole
       changes.
 
 This is a patch release, replacing a defective binary jar in version 2.4.  Other
-than the build configuration (pom.xml), the source distribution for version 2.4.1
-is identical to version 2.4.
+than the build configuration the source distribution for version 2.4.1 is identical
+to version 2.4.
 
 Changes in version 2.4.1 include:
 

Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1682491&r1=1682490&r2=1682491&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Fri May 29 14:40:50 2015
@@ -173,4 +173,34 @@
     <Method name="equals" />
     <Bug pattern="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT" />
   </Match>
+  <Match>
+    <!-- Code needs to use get to ensure latest queue is retrieved -->
+    <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
+    <Method name="clearOldest" />
+    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+  </Match>
+  <Match>
+    <!-- Code needs to use get to ensure latest queue is retrieved -->
+    <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
+    <Method name="getNumWaitersByKey" />
+    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+  </Match>
+  <Match>
+    <!-- Code needs to use get to ensure latest queue is retrieved -->
+    <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
+    <Method name="hasBorrowWaiters" />
+    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+  </Match>
+  <Match>
+    <!-- Code needs to use get to ensure latest queue is retrieved -->
+    <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
+    <Method name="listAllObjects" />
+    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+  </Match>
+  <Match>
+    <!-- Code needs to use get to ensure latest queue is retrieved -->
+    <Class name="org.apache.commons.pool2.impl.GenericKeyedObjectPool" />
+    <Method name="reuseCapacity" />
+    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
+  </Match>
 </FindBugsFilter>

Modified: commons/proper/pool/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/changes.xml?rev=1682491&r1=1682490&r2=1682491&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/changes/changes.xml (original)
+++ commons/proper/pool/trunk/src/changes/changes.xml Fri May 29 14:40:50 2015
@@ -45,8 +45,8 @@ The <action> type attribute can be add,u
   <body>
   <release version="2.4.1" date="TBD" description=
  "This is a patch release, replacing a defective binary jar in version 2.4. Other
-than the build configuration (pom.xml), the source distribution for version 2.4.1
-is identical to version 2.4.">
+than the build configuration, the source distribution for version 2.4.1 is identical
+to version 2.4.">
     <action dev="psteitz" issue="POOL-297" type="fix">
       Reverted coburta plugin update that caused binary jar corruption.
     </action>