You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2008/01/21 20:48:09 UTC
svn commit: r613985 -
/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
Author: dennisl
Date: Mon Jan 21 11:48:08 2008
New Revision: 613985
URL: http://svn.apache.org/viewvc?rev=613985&view=rev
Log:
[MCHANGES-66] The changes plugin scatters white space over its Changes report
Submitted by: Benjamin Bentmann
Reviewed by: Dennis Lundberg
o Applied, but I opted to not remove line breaks, as discussed in the issue.
Modified:
maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java?rev=613985&r1=613984&r2=613985&view=diff
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/changes/ChangesXML.java Mon Jan 21 11:48:08 2008
@@ -45,7 +45,7 @@
private Release release;
- private String currentElement;
+ private StringBuffer currentElement = new StringBuffer( 1024 );
private String currentName;
@@ -116,12 +116,7 @@
public void characters( char[] buf, int offset, int len )
throws SAXException
{
- String s = new String( buf, offset, len );
-
- if ( !s.trim().equals( "" ) )
- {
- currentElement = currentElement + s.trim() + "\n";
- }
+ currentElement.append( buf, offset, len );
}
public void endElement( String namespaceURI, String sName, String qName )
@@ -129,15 +124,15 @@
{
if ( qName.equals( "title" ) )
{
- this.title = currentElement;
+ this.title = currentElement.toString().trim();
}
else if ( qName.equals( "author" ) )
{
- this.title = currentElement;
+ this.title = currentElement.toString().trim();
}
else if ( qName.equals( "action" ) )
{
- action.setAction( currentElement.trim() );
+ action.setAction( currentElement.toString().trim() );
actionList.add( action );
}
@@ -148,7 +143,7 @@
releaseList.add( release );
}
- currentElement = "";
+ currentElement.setLength( 0 );
}
public void startElement( String namespaceURI, String sName, String qName, Attributes attrs )