Re: Review Request 47563: HIVE-13675 LLAP: add HMAC signatures to LLAPIF splits

[Sergey Shelukhin <se...@hortonworks.com>]

> On May 31, 2016, 11:09 p.m., Siddharth Seth wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 2880
> > <https://reviews.apache.org/r/47563/diff/3/?file=1399766#file1399766line2880>
> >
> >     Is this needed ? Can we create the instance on first access instead of adding a config.

We may not have a daemon config when we ask for coordinator, and if we do pass in a config it makes the API brittle cause the question is whether we should handle different configs...
I think it's better to initialize everything at init time. There's a comment somewhere saying it should also be passed around like in normal OOP, not accessed via a global.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47563/#review135706
-----------------------------------------------------------


On May 27, 2016, 9:32 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47563/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 9:32 p.m.)
> 
> 
> Review request for hive, Jason Dere and Siddharth Seth.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see JIRA. Please ignore the first iteration, RB doesn't allow base patches on submit
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6a404bd 
>   llap-client/src/java/org/apache/hadoop/hive/llap/SubmitWorkInfo.java 6704294 
>   llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java 6c2618b 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java f10351b 
>   llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClientImpl.java PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/coordinator/LlapCoordinator.java PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSigner.java PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java 465b204 
>   llap-common/src/java/org/apache/hadoop/hive/llap/security/SigningSecretManager.java PRE-CREATION 
>   llap-common/src/java/org/apache/hadoop/hive/llap/tez/Converters.java e43b72b 
>   llap-common/src/test/org/apache/hadoop/hive/llap/tez/TestConverters.java 349ee14 
>   llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 4306c22 
>   llap-server/src/java/org/apache/hadoop/hive/llap/coordinator/LlapCoordinatorImpl.java PRE-CREATION 
>   llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 2524dc2 
>   llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java PRE-CREATION 
>   llap-server/src/test/org/apache/hadoop/hive/llap/security/TestLlapSignerImpl.java PRE-CREATION 
>   llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 026df3b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java c9b912b 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java 83d492a 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java d61edf5 
> 
> Diff: https://reviews.apache.org/r/47563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>