You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2018/10/31 03:40:22 UTC

pull request 2607

Hi Jeff,

I reviewed your work on PR#2607 [1] today. It looks good, but has two minor
imports issue, pls. see the details from the pull request.

Thanks,
-Ian.

1. https://github.com/apache/incubator-dubbo/pull/2607

Re: pull request 2607

Posted by Ian Luo <ia...@gmail.com>.

I will merge it once it passes CI.

On Wed, Oct 31, 2018 at 2:15 PM RQ <lr...@gmail.com> wrote:

> Ian, thanks your reviewing. I just resolved by some fixings according to
> your advices.
>
> Regards,
> Jeff
>
> Ian Luo <ia...@gmail.com> 于2018年10月31日周三 上午11:40写道：
>
> > Hi Jeff,
> >
> > I reviewed your work on PR#2607 [1] today. It looks good, but has two
> minor
> > imports issue, pls. see the details from the pull request.
> >
> > Thanks,
> > -Ian.
> >
> > 1. https://github.com/apache/incubator-dubbo/pull/2607
> >
>

Re: pull request 2607

Posted by RQ <lr...@gmail.com>.

Ian, thanks your reviewing. I just resolved by some fixings according to
your advices.

Regards,
Jeff

Ian Luo <ia...@gmail.com> 于2018年10月31日周三 上午11:40写道：

> Hi Jeff,
>
> I reviewed your work on PR#2607 [1] today. It looks good, but has two minor
> imports issue, pls. see the details from the pull request.
>
> Thanks,
> -Ian.
>
> 1. https://github.com/apache/incubator-dubbo/pull/2607
>