You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 15:17:11 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #415: use prettier to auto format md files
Jimexist opened a new pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#issuecomment-847126020
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#415](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (694f093) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/7359e4b4df0836b8de970d551c6eeae22d1cc810?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7359e4b) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 694f093 differs from pull request most recent head 0507ed0. Consider uploading reports for the commit 0507ed0 to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 74.85% 74.85%
=======================================
Files 146 146
Lines 24498 24498
=======================================
Hits 18339 18339
Misses 6159 6159
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7359e4b...0507ed0](https://codecov.io/gh/apache/arrow-datafusion/pull/415?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on a change in pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
Jimexist commented on a change in pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#discussion_r642280510
##########
File path: .github/workflows/dev.yml
##########
@@ -23,7 +23,22 @@ on:
pull_request:
jobs:
+ prettier:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ # Make sure the actual branch is checked out when running on pull requests
+ ref: ${{ github.head_ref }}
+
+ - name: Prettify code
+ uses: creyD/prettier_action@v3.3
Review comment:
good point. do you think copying it to be something under apache org repo is desired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#discussion_r642379602
##########
File path: .github/workflows/dev.yml
##########
@@ -23,7 +23,22 @@ on:
pull_request:
jobs:
+ prettier:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ # Make sure the actual branch is checked out when running on pull requests
+ ref: ${{ github.head_ref }}
+
+ - name: Prettify code
+ uses: creyD/prettier_action@v3.3
Review comment:
> good point. do you think copying it to be something under apache org repo is desired?
Yes, I think that would be preferable (the rationale being that then that someone can't change the contents of the action in the third party repository and affect the apache org via a github action)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a change in pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#discussion_r638936568
##########
File path: .github/workflows/dev.yml
##########
@@ -23,7 +23,22 @@ on:
pull_request:
jobs:
+ prettier:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@v2
+ with:
+ # Make sure the actual branch is checked out when running on pull requests
+ ref: ${{ github.head_ref }}
+
+ - name: Prettify code
+ uses: creyD/prettier_action@v3.3
Review comment:
I think apache repos are limited to official github actions or ones that are local to this repo (there were some security issues previously):.
> Notice: December 27, 2020: We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn.
https://infra.apache.org/github-actions-secrets.html
Given https://github.com/creyD/prettier_action appears to be MIT licensed, however, what about copying the code for that action into this repo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#issuecomment-847117103
Now it's automatic! Neat!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#issuecomment-853365994
Seems like this is supserceded by https://github.com/apache/arrow-datafusion/pull/453 so closing this to keep the PR queue down. Please reopen it @Jimexist if that is not correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #415: use prettier to auto format md files
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #415:
URL: https://github.com/apache/arrow-datafusion/pull/415#issuecomment-847995587
FYI @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org